Use StringView for startsWith and endsWith.

Use StringView for startsWith and endsWith.

This lets us collapse lots of the code paths together, and means we can
now handle startsWith(kConst) without doing a strlen or a malloc of a
String object.

BUG=615174
Committed: https://crrev.com/a5673d69964d773f0111e2e6a600ac180587c2f6
Cr-Commit-Position: refs/heads/master@{#405410}

[esprehn, 2016-07-13 23:14:41]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 23:15:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-13 23:42:56]

https://codereview.chromium.org/2146163003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSource.cpp (right):

https://codereview.chromium.org/2146163003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSource.cpp:56: match =
host.endsWith(String("." + m_host), TextCaseInsensitive);
a + b returns a StringAppend, which can't be converted to a StringView. We can
fix this by declaring template<A, B> startsWith(StringAppend<A, B> string) const
{ return startsWith(String(string)); } but I want to save that for another patch
if/when we need it. This is the only place anyone concats a string before
calling these methods today and making the allocation explicit doesn't seem too
bad.

https://codereview.chromium.org/2146163003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/StringImpl.h (left):

https://codereview.chromium.org/2146163003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/StringImpl.h:522: inline bool
equalIgnoringASCIICase(const StringImpl* a, const char* b) { return
equalIgnoringASCIICase(a, reinterpret_cast<const LChar*>(b)); }
These are all handled by the one defined in StringView.h:

equalIgnoringASCIICase(const StringView& a, const StringView& b);

[esprehn, 2016-07-14 00:53:04]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, jrboman@chromium.org, yutak@chromium.org

[haraken, 2016-07-14 00:58:00]

LGTM

[esprehn, 2016-07-14 00:59:35]

The CQ bit was unchecked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-14 00:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[esprehn, 2016-07-14 00:59:37]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-14 00:59:37]

Dry run: CQ bit was unchecked.

[esprehn, 2016-07-14 02:18:26]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:19:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:41:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 02:42:05]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 02:45:01]

Description was changed from

==========
Use StringView for startsWith and endsWith.

This lets us collapse lots of the code paths together, and means we can
now handle startsWith(kConst) without doing a strlen or a malloc of a
String object.

BUG=615174
==========

to

==========
Use StringView for startsWith and endsWith.

This lets us collapse lots of the code paths together, and means we can
now handle startsWith(kConst) without doing a strlen or a malloc of a
String object.

BUG=615174

Committed: https://crrev.com/a5673d69964d773f0111e2e6a600ac180587c2f6
Cr-Commit-Position: refs/heads/master@{#405410}
==========

[commit-bot: I haz the power, 2016-07-14 02:45:02]

Patchset 1 (id:??) landed as
https://crrev.com/a5673d69964d773f0111e2e6a600ac180587c2f6
Cr-Commit-Position: refs/heads/master@{#405410}