Use StringView for startsWith and endsWith.

third_party/WebKit/Source/wtf/text/StringImpl.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 365 matching lines @@
     size_t find(StringImpl*, unsigned index);
     size_t findIgnoringCase(const LChar*, unsigned index = 0);
     ALWAYS_INLINE size_t findIgnoringCase(const char* s, unsigned index = 0) { return findIgnoringCase(reinterpret_cast<const LChar*>(s), index); }
     size_t findIgnoringCase(StringImpl*, unsigned index = 0);
     size_t findIgnoringASCIICase(StringImpl*, unsigned index = 0);
 
     size_t reverseFind(UChar, unsigned index = UINT_MAX);
     size_t reverseFind(StringImpl*, unsigned index = UINT_MAX);
 
     bool startsWith(UChar) const;
-    bool startsWith(const char*, unsigned prefixLength) const;
-    bool startsWith(const StringImpl*) const;
-    bool startsWithIgnoringCase(const char*, unsigned prefixLength) const;
-    bool startsWithIgnoringCase(const StringImpl*) const;
-    bool startsWithIgnoringASCIICase(const char*, unsigned prefixLength) const;
-    bool startsWithIgnoringASCIICase(const StringImpl*) const;
+    bool startsWith(const StringView&) const;
+    bool startsWithIgnoringCase(const StringView&) const;
+    bool startsWithIgnoringASCIICase(const StringView&) const;
 
     bool endsWith(UChar) const;
-    bool endsWith(const char*, unsigned suffixLength) const;
-    bool endsWith(const StringImpl*) const;
-    bool endsWithIgnoringCase(const char*, unsigned suffixLength) const;
-    bool endsWithIgnoringCase(const StringImpl*) const;
-    bool endsWithIgnoringASCIICase(const char*, unsigned suffixLength) const;
-    bool endsWithIgnoringASCIICase(const StringImpl*) const;
+    bool endsWith(const StringView&) const;
+    bool endsWithIgnoringCase(const StringView&) const;
+    bool endsWithIgnoringASCIICase(const StringView&) const;
 
     PassRefPtr<StringImpl> replace(UChar, UChar);
     PassRefPtr<StringImpl> replace(UChar, StringImpl*);
     ALWAYS_INLINE PassRefPtr<StringImpl> replace(UChar pattern, const char* replacement, unsigned replacementLength) { return replace(pattern, reinterpret_cast<const LChar*>(replacement), replacementLength); }
     PassRefPtr<StringImpl> replace(UChar, const LChar*, unsigned replacementLength);
     PassRefPtr<StringImpl> replace(UChar, const UChar*, unsigned replacementLength);
     PassRefPtr<StringImpl> replace(StringImpl*, StringImpl*);
     PassRefPtr<StringImpl> replace(unsigned index, unsigned len, StringImpl*);
     PassRefPtr<StringImpl> upconvertedString();
 
@@ skipping 94 matching lines @@
 template<typename CharacterTypeA, typename CharacterTypeB>
 inline bool equalIgnoringASCIICase(const CharacterTypeA* a, const CharacterTypeB* b, unsigned length)
 {
     for (unsigned i = 0; i < length; ++i) {
         if (toASCIILower(a[i]) != toASCIILower(b[i]))
             return false;
     }
     return true;
 }
 
-WTF_EXPORT bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
-WTF_EXPORT bool equalIgnoringASCIICase(const StringImpl*, const LChar*, unsigned length);
-inline bool equalIgnoringASCIICase(const StringImpl* a, const char* b, unsigned length) { return equalIgnoringASCIICase(a, reinterpret_cast<const LChar*>(b), length); }
-inline bool equalIgnoringASCIICase(const StringImpl* a, const LChar* b)
-{
-    size_t length = b ? strlen(reinterpret_cast<const char*>(b)) : 0;
-    return equalIgnoringASCIICase(a, b, length);
-}
-inline bool equalIgnoringASCIICase(const StringImpl* a, const char* b) { return equalIgnoringASCIICase(a, reinterpret_cast<const LChar*>(b)); }

[esprehn, 2016/07/13 23:42:56]

These are all handled by the one defined in StringView.h:

equalIgnoringASCIICase(const StringView& a, const StringView& b);

-
 WTF_EXPORT int codePointCompareIgnoringASCIICase(const StringImpl*, const LChar*);
 
 inline size_t find(const LChar* characters, unsigned length, LChar matchCharacter, unsigned index = 0)
 {
     // Some clients rely on being able to pass index >= length.
     if (index >= length)
         return kNotFound;
     const LChar* found = static_cast<const LChar*>(
         memchr(characters + index, matchCharacter, length - index));
     return found ? found - characters : kNotFound;
@@ skipping 201 matching lines @@
 
 using WTF::StringImpl;
 using WTF::equal;
 using WTF::equalNonNull;
 using WTF::TextCaseSensitivity;
 using WTF::TextCaseSensitive;
 using WTF::TextCaseASCIIInsensitive;
 using WTF::TextCaseInsensitive;
 
 #endif