Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2146163002: [DevTools] Remove Console.messagesCleared event. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2139543002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove Console.messagesCleared event. This event doesn't make sense. Frontend can clear console messages log on navigation if it wants to. BUG=613882 Committed: https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a Cr-Commit-Position: refs/heads/master@{#405559}

Patch Set 1 #

Patch Set 2 : preserve clear message #

Patch Set 3 : rebased on ToT #

Messages

Total messages: 10 (4 generated)
dgozman
Take a look please.
4 years, 5 months ago (2016-07-13 21:45:49 UTC) #2
lushnikov
lgtm
4 years, 5 months ago (2016-07-13 21:52:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146163002/40001
4 years, 5 months ago (2016-07-14 19:26:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-14 20:43:30 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 20:43:44 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 20:47:41 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/68b12f1c42ff0d66ee403dfd8b499b9d0f87865a
Cr-Commit-Position: refs/heads/master@{#405559}

Powered by Google App Engine
This is Rietveld 408576698