Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2146163002: [DevTools] Remove Console.messagesCleared event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2139543002
Patch Set: rebased on ToT Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
6 6
7 #include "platform/v8_inspector/V8ConsoleMessage.h" 7 #include "platform/v8_inspector/V8ConsoleMessage.h"
8 #include "platform/v8_inspector/V8DebuggerImpl.h" 8 #include "platform/v8_inspector/V8DebuggerImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 void V8ConsoleAgentImpl::clearMessages(ErrorString* errorString) 49 void V8ConsoleAgentImpl::clearMessages(ErrorString* errorString)
50 { 50 {
51 m_session->debugger()->ensureConsoleMessageStorage(m_session->contextGroupId ())->clear(); 51 m_session->debugger()->ensureConsoleMessageStorage(m_session->contextGroupId ())->clear();
52 } 52 }
53 53
54 void V8ConsoleAgentImpl::restore() 54 void V8ConsoleAgentImpl::restore()
55 { 55 {
56 if (!m_state->booleanProperty(ConsoleAgentState::consoleEnabled, false)) 56 if (!m_state->booleanProperty(ConsoleAgentState::consoleEnabled, false))
57 return; 57 return;
58 m_frontend.messagesCleared();
59 ErrorString ignored; 58 ErrorString ignored;
60 enable(&ignored); 59 enable(&ignored);
61 } 60 }
62 61
63 void V8ConsoleAgentImpl::messageAdded(V8ConsoleMessage* message) 62 void V8ConsoleAgentImpl::messageAdded(V8ConsoleMessage* message)
64 { 63 {
65 if (m_enabled) 64 if (m_enabled)
66 reportMessage(message, true); 65 reportMessage(message, true);
67 } 66 }
68 67
69 void V8ConsoleAgentImpl::reset()
70 {
71 if (m_enabled)
72 m_frontend.messagesCleared();
73 }
74
75 bool V8ConsoleAgentImpl::enabled() 68 bool V8ConsoleAgentImpl::enabled()
76 { 69 {
77 return m_enabled; 70 return m_enabled;
78 } 71 }
79 72
80 void V8ConsoleAgentImpl::reportAllMessages() 73 void V8ConsoleAgentImpl::reportAllMessages()
81 { 74 {
82 V8ConsoleMessageStorage* storage = m_session->debugger()->ensureConsoleMessa geStorage(m_session->contextGroupId()); 75 V8ConsoleMessageStorage* storage = m_session->debugger()->ensureConsoleMessa geStorage(m_session->contextGroupId());
83 if (storage->expiredCount()) { 76 if (storage->expiredCount()) {
84 std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::C onsole::ConsoleMessage::create() 77 std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::C onsole::ConsoleMessage::create()
(...skipping 16 matching lines...) Expand all
101 } 94 }
102 95
103 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 96 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
104 { 97 {
105 DCHECK_EQ(V8MessageOrigin::kConsole, message->origin()); 98 DCHECK_EQ(V8MessageOrigin::kConsole, message->origin());
106 message->reportToFrontend(&m_frontend, m_session, generatePreview); 99 message->reportToFrontend(&m_frontend, m_session, generatePreview);
107 m_frontend.flush(); 100 m_frontend.flush();
108 } 101 }
109 102
110 } // namespace blink 103 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698