mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc - Issue 2146153002: Mojo typemap config: support "copyable_pass_by_value" attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

Issue 2146153002: Mojo typemap config: support "copyable_pass_by_value" attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@69_change_move_only

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h ('k') | mojo/public/interfaces/bindings/tests/struct_with_traits.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

diff --git a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

index c11b37ab2d48f66eb26413d4975b0449119b62f0..017d3703dac793b3c5d327431270942357e1f305 100644

--- a/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

+++ b/mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.cc

@@ -116,10 +116,10 @@ bool StructTraits<test::StructWithTraits, test::StructWithTraitsImpl>::Read(

}

// static

-bool StructTraits<test::PassByValueStructWithTraits,

- test::PassByValueStructWithTraitsImpl>::

- Read(test::PassByValueStructWithTraits::DataView data,

- test::PassByValueStructWithTraitsImpl* out) {

+bool StructTraits<test::MoveOnlyStructWithTraits,

+ test::MoveOnlyStructWithTraitsImpl>::

+ Read(test::MoveOnlyStructWithTraits::DataView data,

+ test::MoveOnlyStructWithTraitsImpl* out) {

out->get_mutable_handle() = data.TakeFHandle();

return true;

}