Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146063003:
fix gyp build after CL2147613002 (Closed)
|
Created:
4 years, 5 months ago by Mostyn Bramley-Moore Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionfix gyp build after proto_zero_plugin skeleton landed
Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002
BUG=608721
Committed: https://crrev.com/3671b588234ec348707f079dea4b151164ffcb9b
Cr-Commit-Position: refs/heads/master@{#405330}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== fix gyp build after CL2147613002 BUG=608721 ========== to ========== fix gyp build after CL2147613002 BUG=608721 ==========
mostynb@opera.com changed reviewers: + kraynov@chromium.org, primiano@chromium.org
@primiano, kraynov: please take a look at this small gyp fixup after https://codereview.chromium.org/2147613002
lgtm Thank you for pointing on the issue.
But please fix description with crrev.com/2147613002
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== fix gyp build after CL2147613002 BUG=608721 ========== to ========== fix gyp build after proto_zero_plugin skeleton landed Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002 BUG=608721 ==========
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== fix gyp build after proto_zero_plugin skeleton landed Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002 BUG=608721 ========== to ========== fix gyp build after proto_zero_plugin skeleton landed Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002 BUG=608721 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== fix gyp build after proto_zero_plugin skeleton landed Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002 BUG=608721 ========== to ========== fix gyp build after proto_zero_plugin skeleton landed Followup to https://codereview.chromium.org/2147613002 / crrev.com/2147613002 BUG=608721 Committed: https://crrev.com/3671b588234ec348707f079dea4b151164ffcb9b Cr-Commit-Position: refs/heads/master@{#405330} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3671b588234ec348707f079dea4b151164ffcb9b Cr-Commit-Position: refs/heads/master@{#405330} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
