Skeleton for proto_zero_plugin.

Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721
Committed: https://crrev.com/89c7bc1f95f8beb30cd563bc4fcfa2bbab136e03
Cr-Commit-Position: refs/heads/master@{#405281}

[kraynov, 2016-07-12 16:35:16]

kraynov@chromium.org changed reviewers:
+ primiano@chromium.org

[kraynov, 2016-07-12 16:35:17]

Please take a look. Thank you!

[kraynov, 2016-07-13 12:21:04]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 12:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 13:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 13:24:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kraynov, 2016-07-13 14:34:28]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 14:34:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kraynov, 2016-07-13 15:46:32]

Roadmap:

Second CL:
- Put full implementation of plugin (with commented runtime calls)
- README.chromium

Third CL:
- Adjustments to Primiano's proto zero runtime
- Uncommenting runtime calls
- Tests for generated stubs

Fourth CL:
- Executable path evaluation in proto_library.gni

[Primiano Tucci (use gerrit), 2016-07-13 16:52:32]

Ok have very few comments. They are on the previous patchset but should apply
anyway. The rest is great

https://codereview.chromium.org/2147613002/diff/20001/components/components_t...
File components/components_tests.gyp (right):

https://codereview.chromium.org/2147613002/diff/20001/components/components_t...
components/components_tests.gyp:883:
'tracing/proto_zero_plugin/mock_messages_unittest.cc',
see my comments about naming  in the gn file. The same clearly will apply to gyp
:)

https://codereview.chromium.org/2147613002/diff/20001/components/tracing.gyp
File components/tracing.gyp (right):

https://codereview.chromium.org/2147613002/diff/20001/components/tracing.gyp#...
components/tracing.gyp:78: 'target_name': 'mock_messages',
call this target "proto_zero_test_message"
this target name has a global visibility, mock_messages is super generic.

https://codereview.chromium.org/2147613002/diff/20001/components/tracing.gyp#...
components/tracing.gyp:84: 'generator_plugin_suffix': '.zeropb',
i'd make this .pbzero for consistency with ProtoZeroMessage naming

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/BUIL...
File components/tracing/BUILD.gn (right):

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/BUIL...
components/tracing/BUILD.gn:65: "proto_zero_plugin/mock_messages_unittest.cc",
this file should NOT be inside the tools/proto_zero_plugin folder, because it
tests the result of the generation, not the generator code itself (which is
fine).
Move it to components/tracing/test/proto_zero_message_generation_unittest.cc

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
File components/tracing/proto_zero_plugin/BUILD.gn (right):

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
components/tracing/proto_zero_plugin/BUILD.gn:21: proto_library("mock_messages")
{
ditto about proto_zero_examples

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
components/tracing/proto_zero_plugin/BUILD.gn:30: get_label_info(plugin_label,
"root_out_dir") + "/proto_zero_plugin",
uh, this is interestingly long. Did you take this from somewhere or came up
yourself with this?

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
File components/tracing/proto_zero_plugin/mock_messages.proto (right):

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
components/tracing/proto_zero_plugin/mock_messages.proto:1: // Copyright 2016
The Chromium Authors. All rights reserved.
call this example_message.proto

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
File components/tracing/proto_zero_plugin/proto_zero_generator.cc (right):

https://codereview.chromium.org/2147613002/diff/20001/components/tracing/prot...
components/tracing/proto_zero_plugin/proto_zero_generator.cc:69: }
nit: add  "  // namespace" comment

[commit-bot: I haz the power, 2016-07-13 17:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 17:08:23]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-07-13 17:22:37]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 17:23:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-07-13 17:49:29]

primiano@chromium.org changed reviewers:
+ xyzzyz@chromium.org

[Primiano Tucci (use gerrit), 2016-07-13 17:49:30]

Awesome.
LGTM from my viewpoint.
+xyzzyz as he has reviews the GN changes and you need a protobuf owner for
adding the DEPS entry.
+oysteine FYI


Also IIRC thakis asked to send a design doc for this plugin on chromium-dev.
I'll do that tomorrow EMEA time.

[xyzzyz, 2016-07-13 18:12:48]

DEPS lgtm

[commit-bot: I haz the power, 2016-07-13 18:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:30:44]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kraynov, 2016-07-13 18:40:23]

Description was changed from

==========
Skeleton for proto_zero_plugin.

Partial implementation of custom protobuf compiler plugin for
Tracing V2. This CL contains all necessary changes to build files
and complete implementation will be landed on top of it.

BUG=608721
==========

to

==========
Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721
==========

[kraynov, 2016-07-13 18:41:27]

The CQ bit was checked by kraynov@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:42:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:38:04]

Description was changed from

==========
Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721
==========

to

==========
Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721
==========

[commit-bot: I haz the power, 2016-07-13 20:38:05]

Committed patchset #6 (id:70011)

[commit-bot: I haz the power, 2016-07-13 20:40:15]

Description was changed from

==========
Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721
==========

to

==========
Skeleton for ProtoZero plugin.

ProtoZero plugin is a custom C++ stubs generator for protobuf compiler.
These stubs are Tracing V2 specific and meet perfomance and memory
requirements being less functional than conventional ones.
This CL has no complete implementation (see crrev.com/2083373002) but
contains all invasive changes to build files.
See crrev.com/2082693002 for background about protobuf plugin support.

BUG=608721

Committed: https://crrev.com/89c7bc1f95f8beb30cd563bc4fcfa2bbab136e03
Cr-Commit-Position: refs/heads/master@{#405281}
==========

[commit-bot: I haz the power, 2016-07-13 20:40:16]

Patchset 6 (id:??) landed as
https://crrev.com/89c7bc1f95f8beb30cd563bc4fcfa2bbab136e03
Cr-Commit-Position: refs/heads/master@{#405281}