Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2145993003: blink: Remove uses of blink variant bindings in content (Closed)

Created:
4 years, 5 months ago by ortuno
Modified:
4 years, 5 months ago
Reviewers:
esprehn, dcheng
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Remove uses of blink variant bindings in content Including a blink variant binding in content/renderer means that content/renderer includes all of wtf/. Sadly this means that we can no longer use the same enum in content/renderer and blink so we static cast at the boundary. Committed: https://crrev.com/ca57d598bf5b672a4ffd9372475aec13cae5737f Cr-Commit-Position: refs/heads/master@{#405498}

Patch Set 1 #

Patch Set 2 : Remove dependency on blink bindings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M content/renderer/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/modules/notifications/WebNotificationPermissionCallback.h View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
ortuno
dcheng: PTAL at t/WebKit esprehn: PTAL at content/renderer Let me know if you have any ...
4 years, 5 months ago (2016-07-13 17:56:07 UTC) #2
Peter Beverloo
See crbug.com/621177 for discussion. I would still be in favor of allowing //content/{child, renderer}/ to ...
4 years, 5 months ago (2016-07-13 18:38:23 UTC) #7
esprehn
lgtm
4 years, 5 months ago (2016-07-14 00:39:23 UTC) #10
dcheng
LGTM, as long as the eventual state isn't static casting an enum to/from an int32.
4 years, 5 months ago (2016-07-14 02:36:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145993003/20001
4 years, 5 months ago (2016-07-14 14:44:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 15:13:27 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 15:13:29 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 15:15:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca57d598bf5b672a4ffd9372475aec13cae5737f
Cr-Commit-Position: refs/heads/master@{#405498}

Powered by Google App Engine
This is Rietveld 408576698