Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2171)

Unified Diff: chrome/browser/media/router/mojo/media_router.mojom

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to apacible@ comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router.mojom
diff --git a/chrome/browser/media/router/mojo/media_router.mojom b/chrome/browser/media/router/mojo/media_router.mojom
index 816527e1d1d0c9cd3d1fc8f3cc37cb230a49a85a..39e28a57a0433d944de53a1b2e24e6e1b8ab3d29 100644
--- a/chrome/browser/media/router/mojo/media_router.mojom
+++ b/chrome/browser/media/router/mojo/media_router.mojom
@@ -122,13 +122,19 @@ struct SinkSearchCriteria {
string domain;
};
-// Maps to a ResultCode value in route_request_result.h
-// The enum defined here is a subset of those defined in route_request_result.h.
+// Keep in sync with:
+// - RouteRequestResult::ResultCode in route_request_result.h
+// - MediaRouteProviderResult enum in tools/metrics/histograms.xml.
+// - mr.RouteRequestResultCode in route_request_error.js
enum RouteRequestResultCode {
UNKNOWN_ERROR,
OK,
TIMED_OUT,
- ROUTE_NOT_FOUND
+ ROUTE_NOT_FOUND,
+ SINK_NOT_FOUND,
+ INVALID_ORIGIN,
+ OFF_THE_RECORD_MISMATCH,
+ NO_SUPPORTED_PROVIDER
};
// Modeled after the MediaRouter interface defined in
@@ -229,8 +235,12 @@ interface MediaRouteProvider {
string? error_text,
RouteRequestResultCode result_code);
- // Terminates the route specified by |route_id|.
- TerminateRoute(string route_id);
+ // Terminates the route specified by |route_id|. If the route was terminated
+ // successfully, |result_code| is set to OK and |error_text| is null.
+ // Otherwise, |result_code| is an error code and |error_text| describes the
+ // error.
+ TerminateRoute(string route_id) =>
+ (string? error_text, RouteRequestResultCode result_code);
// Sends |message| via the media route |media_route_id|.
// If the operation was successful, |sent| is true; otherwise it is false.

Powered by Google App Engine
This is Rietveld 408576698