chrome/browser/media/router/mojo/media_router_type_converters.cc - Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_type_converters.cc

Issue 2145983003: [Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to apacible@ comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/mojo/media_router_mojo_test.h ('k') | chrome/browser/media/router/route_request_result.h » ('j') | extensions/renderer/resources/media_router_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_type_converters.cc

diff --git a/chrome/browser/media/router/mojo/media_router_type_converters.cc b/chrome/browser/media/router/mojo/media_router_type_converters.cc

index cd61522653db743123c1b6c33ca01a807a532552..eedb771df69e477689d7e66de675742206cf7667 100644

--- a/chrome/browser/media/router/mojo/media_router_type_converters.cc

+++ b/chrome/browser/media/router/mojo/media_router_type_converters.cc

@@ -185,6 +185,8 @@ media_router::RouteRequestResult::ResultCode RouteRequestResultCodeFromMojo(

return media_router::RouteRequestResult::TIMED_OUT;

case RouteRequestResultCode::ROUTE_NOT_FOUND:

return media_router::RouteRequestResult::ROUTE_NOT_FOUND;

+ case RouteRequestResultCode::SINK_NOT_FOUND:

+ return media_router::RouteRequestResult::SINK_NOT_FOUND;

imcheng 2016/07/15 20:18:45 Do you also need to add INVALID_ORIGIN, OFF_THE_RE

mark a. foltz 2016/07/15 20:48:41 Done.

default:

NOTREACHED() << "Unknown RouteRequestResultCode " << result_code;

return media_router::RouteRequestResult::UNKNOWN_ERROR;