Add simpler API for changing parameters in tests.

Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013
Committed: https://crrev.com/86e3d75af3140dce0826f797da9fbadb5bf952bd
Cr-Commit-Position: refs/heads/master@{#405992}

[jkrcal, 2016-07-13 12:20:29]

jkrcal@chromium.org changed reviewers:
+ asvitkine@chromium.org

[jkrcal, 2016-07-13 12:20:29]

Hi Alexei,

PTAL.

I was really missing this - what do you think?

[jkrcal, 2016-07-13 12:50:06]

For first simple use, please see https://codereview.chromium.org/2146863002/.

[Alexei Svitkine (slow), 2016-07-15 14:51:01]

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
File components/variations/variations_associated_data.cc (right):

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.cc:275: new
base::FieldTrialList(new metrics::SHA1EntropyProvider(kEntropy)));
You can just pass nullptr here.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
File components/variations/variations_associated_data.h (right):

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:168: // your tests. You can
directly set the parameters in the constructor (if they
Also mention that it creates a FieldTrialList as a member.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:171: // are automatically
cleared when this class is destructed so it works well for
Please make this sentence more precise to specify that this class will clear all
params on destruction, not just ones it registered.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:177: 
Nit: No need for empty line here.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:188: };
DISALLOW_COPY_AND_ASSIGN()

[jkrcal, 2016-07-18 09:26:37]

Description was changed from

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.
==========

to

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013
==========

[jkrcal, 2016-07-18 13:09:02]

Thanks, PTAL, again.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
File components/variations/variations_associated_data.cc (right):

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.cc:275: new
base::FieldTrialList(new metrics::SHA1EntropyProvider(kEntropy)));
On 2016/07/15 14:51:01, Alexei Svitkine (slow) wrote:
> You can just pass nullptr here.

Done.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
File components/variations/variations_associated_data.h (right):

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:168: // your tests. You can
directly set the parameters in the constructor (if they
On 2016/07/15 14:51:01, Alexei Svitkine (slow) wrote:
> Also mention that it creates a FieldTrialList as a member.

Done.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:171: // are automatically
cleared when this class is destructed so it works well for
On 2016/07/15 14:51:01, Alexei Svitkine (slow) wrote:
> Please make this sentence more precise to specify that this class will clear
all
> params on destruction, not just ones it registered.

Done.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:177: 
On 2016/07/15 14:51:01, Alexei Svitkine (slow) wrote:
> Nit: No need for empty line here.

Done.

https://codereview.chromium.org/2145963002/diff/20001/components/variations/v...
components/variations/variations_associated_data.h:188: };
On 2016/07/15 14:51:01, Alexei Svitkine (slow) wrote:
> DISALLOW_COPY_AND_ASSIGN()

Done.

[jkrcal, 2016-07-18 13:09:09]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 13:09:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:39:06]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-07-18 14:40:16]

lgtm

[jkrcal, 2016-07-18 15:03:42]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2016-07-18 15:04:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 15:09:48]

Description was changed from

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013
==========

to

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013
==========

[commit-bot: I haz the power, 2016-07-18 15:09:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 15:11:58]

Description was changed from

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013
==========

to

==========
Add simpler API for changing parameters in tests.

When in need of changing variation parameters in unittests, one has to
dig unneccessarily deep into the inner workings of variations::.

This CL adds a simple class to use in unittests.
Simplifying existing unittest code is a matter of further CLs.

BUG=629013

Committed: https://crrev.com/86e3d75af3140dce0826f797da9fbadb5bf952bd
Cr-Commit-Position: refs/heads/master@{#405992}
==========

[commit-bot: I haz the power, 2016-07-18 15:12:00]

Patchset 3 (id:??) landed as
https://crrev.com/86e3d75af3140dce0826f797da9fbadb5bf952bd
Cr-Commit-Position: refs/heads/master@{#405992}