Add simpler API for changing parameters in tests.

components/variations/variations_associated_data.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_VARIATIONS_VARIATIONS_ASSOCIATED_DATA_H_
 #define COMPONENTS_VARIATIONS_VARIATIONS_ASSOCIATED_DATA_H_
 
 #include <map>
 #include <string>
 
@@ skipping 146 matching lines @@
 // variation params, returns false and does not modify |params|. Calling this
 // function will result in the associated field trial being marked as active if
 // found (i.e. group() will be called on it), if it wasn't already. Currently,
 // this information is only available from the browser process. Thread safe.
 std::string GetVariationParamValueByFeature(const base::Feature& feature,
                                             const std::string& param_name);
 
 // Expose some functions for testing.
 namespace testing {
 
+// Use this class as a member in your test class to set variation params for
+// your tests. You can directly set the parameters in the constructor (if they

[Alexei Svitkine (slow), 2016/07/15 14:51:01]

Also mention that it creates a FieldTrialList as a member.

[jkrcal, 2016/07/18 13:09:01]

Done.

+// are used by other members upon construction). You can change them later
+// arbitrarily many times using the SetVariationParams function. The parameters
+// are automatically cleared when this class is destructed so it works well for

[Alexei Svitkine (slow), 2016/07/15 14:51:01]

Please make this sentence more precise to specify that this class will clear all
params on destruction, not just ones it registered.

[jkrcal, 2016/07/18 13:09:01]

Done.

+// multiple tests of a given test class.
+class VariationParamsManager {
+ public:
+  VariationParamsManager(const std::string& trial_name,
+                         const std::map<std::string, std::string>& params);
+

[Alexei Svitkine (slow), 2016/07/15 14:51:01]

Nit: No need for empty line here.

[jkrcal, 2016/07/18 13:09:01]

Done.

+  ~VariationParamsManager();
+
+  // Associates |params| with the given |trial_name|. It creates a new group,
+  // used only for testing. Between two calls of this function,
+  // ClearAllVariationParams() has to be called.
+  void SetVariationParams(const std::string& trial_name,
+                          const std::map<std::string, std::string>& params);
+
+ private:
+  std::unique_ptr<base::FieldTrialList> field_trial_list_;
+};

[Alexei Svitkine (slow), 2016/07/15 14:51:01]

DISALLOW_COPY_AND_ASSIGN()

[jkrcal, 2016/07/18 13:09:01]

Done.

+
 // Clears all of the mapped associations.
 void ClearAllVariationIDs();
 
 // Clears all of the associated params.
 void ClearAllVariationParams();
 
 }  // namespace testing
 
 }  // namespace variations
 
 #endif  // COMPONENTS_VARIATIONS_VARIATIONS_ASSOCIATED_DATA_H_