Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2145863003: Cleanup: remove unused compilationFinishTime + fix a comment. (Closed)

Created:
4 years, 5 months ago by marja
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove unused compilationFinishTime + fix a comment. R=haraken@chromium.org BUG= Committed: https://crrev.com/e3a724bd54f681d4ef051dae6a3e1123d659f255 Cr-Commit-Position: refs/heads/master@{#405130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 5 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
marja
Cleaning up some leftover code from myself - I don't see any usage for this ...
4 years, 5 months ago (2016-07-13 11:12:49 UTC) #1
haraken
LGTM
4 years, 5 months ago (2016-07-13 11:13:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145863003/1
4 years, 5 months ago (2016-07-13 11:25:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 12:45:39 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 12:46:55 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e3a724bd54f681d4ef051dae6a3e1123d659f255
Cr-Commit-Position: refs/heads/master@{#405130}

Powered by Google App Engine
This is Rietveld 408576698