third_party/WebKit/Source/core/dom/ScriptRunner.cpp - Issue 2145863003: Cleanup: remove unused compilationFinishTime + fix a comment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

Issue 2145863003: Cleanup: remove unused compilationFinishTime + fix a comment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

index be56e65b507d5aac8a40979a91ab809f6f82648d..317ce05e0fc46b52fe62cb63d936b495d201b36a 100644

--- a/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptRunner.cpp

@@ -149,7 +149,7 @@ void ScriptRunner::notifyScriptLoadError(ScriptLoader* scriptLoader, ExecutionTy

{

switch (executionType) {

case ASYNC_EXECUTION: {

- // RELEASE_ASSERT makes us crash in a controlled way in error cases

+ // SECURITY_CHECK makes us crash in a controlled way in error cases

// where the ScriptLoader is associated with the wrong ScriptRunner

// (otherwise we'd cause a use-after-free in ~ScriptRunner when it tries

// to detach).

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptLoader.cpp ('k') | no next file » | no next file with comments »