Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180
Committed: https://crrev.com/84452f6f0c65b006ca8646553147f3386e8b57ca
Cr-Commit-Position: refs/heads/master@{#405368}

[ymalik, 2016-07-13 00:47:26]

Description was changed from

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

BUG=599180
==========

to

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

BUG=599180
==========

[ymalik, 2016-07-13 00:47:26]

ymalik@chromium.org changed reviewers:
+ skobes@chromium.org

[ymalik, 2016-07-13 00:47:34]

https://codereview.chromium.org/2145823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/2145823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/UseCounter.cpp:568: case
CSSPropertyOverflowAnchor: return 538;
Need to update histogram.xml. Waiting for
https://codereview.chromium.org/2140173002/ to land.

[skobes, 2016-07-13 15:45:11]

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:265: overflow-anchor
type_name=EOverflowAnchor
alphabetize (before overflow-wrap)

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
(right):

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h:39:
bool anchorScroll() const override;
Why isn't this just in ScrollableArea?

[ymalik, 2016-07-13 19:49:39]

@skobes ptal :)

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:265: overflow-anchor
type_name=EOverflowAnchor
On 2016/07/13 15:45:11, skobes wrote:
> alphabetize (before overflow-wrap)

Done.

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h
(right):

https://codereview.chromium.org/2145823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.h:39:
bool anchorScroll() const override;
On 2016/07/13 15:45:11, skobes wrote:
> Why isn't this just in ScrollableArea?

ScrollableArea is in platform and the definition queries LayoutBox which is in
core and cannot be accessed from platform.

[skobes, 2016-07-13 19:59:58]

lgtm w/ nit

https://codereview.chromium.org/2145823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/2145823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:283: virtual bool
anchorScroll() const { return false; }
Call this something clearer like shouldPerformScrollAnchoring.

[ymalik, 2016-07-13 20:14:58]

ymalik@chromium.org changed reviewers:
+ isherman@chromium.org, jbroman@chromium.org

[ymalik, 2016-07-13 20:14:59]

+jbroman for Source/platform
+isherman for histograms.xml

https://codereview.chromium.org/2145823002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/ScrollableArea.h (right):

https://codereview.chromium.org/2145823002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/ScrollableArea.h:283: virtual bool
anchorScroll() const { return false; }
On 2016/07/13 19:59:58, skobes wrote:
> Call this something clearer like shouldPerformScrollAnchoring.

Done.

[jbroman, 2016-07-13 20:53:05]

https://codereview.chromium.org/2145823002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2145823002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:264: overflow-anchor
type_name=EOverflowAnchor
Should this be guarded by RuntimeEnabledFeatures (e.g. so that authors can
accurately feature-detect)?

[jbroman, 2016-07-13 20:54:13]

Also, could you please link to the Intent to Implement and Ship for this
property? I cannot find it.

[Ilya Sherman, 2016-07-13 20:58:32]

histograms.xml lgtm

[ymalik, 2016-07-13 21:41:31]

On 2016/07/13 20:54:13, jbroman wrote:
> Also, could you please link to the Intent to Implement and Ship for this
> property? I cannot find it.

The intent to implement is in progress, and I'll link it in the description
before landing this CL.

[ymalik, 2016-07-13 21:41:45]

https://codereview.chromium.org/2145823002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2145823002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:264: overflow-anchor
type_name=EOverflowAnchor
On 2016/07/13 20:53:05, jbroman wrote:
> Should this be guarded by RuntimeEnabledFeatures (e.g. so that authors can
> accurately feature-detect)?

Yes totally. And also because we haven't shipped scroll anchoring yet and it
doesn't make sense to ship this before that.

[ymalik, 2016-07-13 22:20:03]

Description was changed from

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

BUG=599180
==========

to

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180
==========

[ymalik, 2016-07-13 22:20:28]

On 2016/07/13 20:54:13, jbroman wrote:
> Also, could you please link to the Intent to Implement and Ship for this
> property? I cannot find it.

Intent to Implemented added to description.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

[jbroman, 2016-07-13 22:22:24]

lgtm

[jbroman, 2016-07-13 22:22:34]

lgtm

[ymalik, 2016-07-13 22:56:27]

The CQ bit was checked by ymalik@chromium.org

[ymalik, 2016-07-13 22:56:28]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2145823002/#ps80001
(title: "Put opt-out behind RuntimeEnabledFeature and update tests")

[commit-bot: I haz the power, 2016-07-13 22:57:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 00:41:32]

Description was changed from

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180
==========

to

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180
==========

[commit-bot: I haz the power, 2016-07-14 00:41:34]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-14 00:43:02]

Description was changed from

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180
==========

to

==========
Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

This CL implements the opt-out described in the ScrollAnchoring explainer:
https://github.com/WICG/interventions/blob/master/scroll-anchoring/explainer.md

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/TbuxbOtyZvk

BUG=599180

Committed: https://crrev.com/84452f6f0c65b006ca8646553147f3386e8b57ca
Cr-Commit-Position: refs/heads/master@{#405368}
==========

[commit-bot: I haz the power, 2016-07-14 00:43:04]

Patchset 5 (id:??) landed as
https://crrev.com/84452f6f0c65b006ca8646553147f3386e8b57ca
Cr-Commit-Position: refs/heads/master@{#405368}

[Rick Byers, 2016-11-19 15:30:44]

Why no tests for this new API?

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=667052

[skobes, 2016-11-20 00:03:00]

On 2016/11/19 15:30:44, Rick Byers wrote:
> Why no tests for this new API?
> 
> Filed https://bugs.chromium.org/p/chromium/issues/detail?id=667052

This patch adds two test cases in ScrollAnchorTest.cpp.

[Rick Byers, 2016-11-21 16:46:50]

On 2016/11/20 00:03:00, skobes wrote:
> On 2016/11/19 15:30:44, Rick Byers wrote:
> > Why no tests for this new API?
> > 
> > Filed https://bugs.chromium.org/p/chromium/issues/detail?id=667052
> 
> This patch adds two test cases in ScrollAnchorTest.cpp.

Of course it does :-).  I'm sorry I totally missed that - should have looked at
the file list more carefully.

[Ilya Sherman, 2016-11-21 18:31:01]

histograms.xml lgtm

[Ilya Sherman, 2016-11-21 18:31:47]

On 2016/11/21 18:31:01, Ilya Sherman wrote:
> histograms.xml lgtm

Sorry, missed that this already landed...
<.<
>.>
<.<