third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2145823002: Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2145823002: Implement the overflow-anchor CSS property as an opt-out for ScrollAnchoring (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put opt-out behind RuntimeEnabledFeature and update tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index b0b2204dec5d9fe9f107349381a05cb29b66ccee..8f5d6fb33f8b9fe0804b06bc60f51b422a48628d 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -294,6 +294,7 @@ void ComputedStyle::copyNonInheritedFromCached(const ComputedStyle& other)

// See comments for each skipped flag below.

m_nonInheritedData.m_effectiveDisplay = other.m_nonInheritedData.m_effectiveDisplay;

m_nonInheritedData.m_originalDisplay = other.m_nonInheritedData.m_originalDisplay;

+ m_nonInheritedData.m_overflowAnchor = other.m_nonInheritedData.m_overflowAnchor;

m_nonInheritedData.m_overflowX = other.m_nonInheritedData.m_overflowX;

m_nonInheritedData.m_overflowY = other.m_nonInheritedData.m_overflowY;

m_nonInheritedData.m_verticalAlign = other.m_nonInheritedData.m_verticalAlign;