Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2145803002: [Android] Add accessibility announcement when switching tab models (Closed)

Created:
4 years, 5 months ago by mcdavid
Modified:
4 years, 5 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add accessibility announcement when switching tab models This patch adds audio feedback when switching between tab stacks within the accessibility tab switcher. BUG=627653 Committed: https://crrev.com/006287e9db9fe5d37861587c70cf5c9f88d76f2f Cr-Commit-Position: refs/heads/master@{#405346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mcdavid
This patch is a small improvement when using the accessibility tab switcher. PTAL, thanks!
4 years, 5 months ago (2016-07-12 23:57:08 UTC) #3
David Trainor- moved to gerrit
lgtm! I don't remember, but I think on tablets we use the tab strip in ...
4 years, 5 months ago (2016-07-13 19:48:11 UTC) #4
mcdavid
On 2016/07/13 19:48:11, David Trainor wrote: > lgtm! I don't remember, but I think on ...
4 years, 5 months ago (2016-07-13 21:56:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145803002/1
4 years, 5 months ago (2016-07-13 21:56:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 23:13:34 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 23:13:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 23:16:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/006287e9db9fe5d37861587c70cf5c9f88d76f2f
Cr-Commit-Position: refs/heads/master@{#405346}

Powered by Google App Engine
This is Rietveld 408576698