Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: src/heap/heap.cc

Issue 2145683003: Flush the optimizing compilejob queue when doing memory pressure GCs (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index b3b24930e2d4329da1431ee842d0237be151705d..ac84dd284b4453c69432eb476c552302003036bd 100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4404,6 +4404,11 @@ void Heap::CollectGarbageOnMemoryPressure(const char* source) {
if (potential_garbage >= kGarbageThresholdInBytes &&
potential_garbage >=
CommittedMemory() * kGarbageThresholdAsFractionOfTotalMemory) {
+ if (isolate()->concurrent_recompilation_enabled()) {
Hannes Payer (out of office) 2016/07/13 14:53:41 Why is the flushing guarded by the potential garba
+ // The optimizing compiler may be unnecessarily holding on to memory.
+ DisallowHeapAllocation no_recursive_gc;
+ isolate()->optimizing_compile_dispatcher()->Flush();
+ }
// If we spent less than half of the time budget, then perform full GC
// Otherwise, start incremental marking.
if (end - start < kMaxMemoryPressurePauseMs / 2) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698