Flush the optimizing compilejob queue when doing memory pressure GCs

src/heap/heap.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/heap.h"
 
 #include "src/accessors.h"
 #include "src/api.h"
 #include "src/ast/scopeinfo.h"
 #include "src/base/bits.h"
@@ skipping 4386 matching lines @@
   double end = MonotonicallyIncreasingTimeInMs();
 
   // Estimate how much memory we can free.
   int64_t potential_garbage =
       (CommittedMemory() - SizeOfObjects()) + external_memory_;
   // If we can potentially free large amount of memory, then start GC right
   // away instead of waiting for memory reducer.
   if (potential_garbage >= kGarbageThresholdInBytes &&
       potential_garbage >=
           CommittedMemory() * kGarbageThresholdAsFractionOfTotalMemory) {
+    if (isolate()->concurrent_recompilation_enabled()) {

[Hannes Payer (out of office), 2016/07/13 14:53:41]

Why is the flushing guarded by the potential garbage condition? Why don't we
always flush on memory pressure?

+      // The optimizing compiler may be unnecessarily holding on to memory.
+      DisallowHeapAllocation no_recursive_gc;
+      isolate()->optimizing_compile_dispatcher()->Flush();
+    }
     // If we spent less than half of the time budget, then perform full GC
     // Otherwise, start incremental marking.
     if (end - start < kMaxMemoryPressurePauseMs / 2) {
       CollectAllGarbage(
           kReduceMemoryFootprintMask | kAbortIncrementalMarkingMask, source,
           kGCCallbackFlagCollectAllAvailableGarbage);
     } else {
       if (FLAG_incremental_marking && incremental_marking()->IsStopped()) {
         StartIdleIncrementalMarking();
       }
@@ skipping 2011 matching lines @@
 }
 
 
 // static
 int Heap::GetStaticVisitorIdForMap(Map* map) {
   return StaticVisitorBase::GetVisitorId(map);
 }
 
 }  // namespace internal
 }  // namespace v8