Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2145683003:
Flush the optimizing compilejob queue when doing memory pressure GCs (Closed)
|
Created:
4 years, 5 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 5 months ago CC:
Hannes Payer (out of office), v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionFlush the optimizing compilejob queue when doing memory pressure GCs
R=ulan@chromium.org,hpayer@chromium.org
BUG=
Committed: https://crrev.com/906cb204d069de8d1a27f2039d0c1c1509a6ad89
Cr-Commit-Position: refs/heads/master@{#37726}
Patch Set 1 #
Total comments: 1
Patch Set 2 : updates #Patch Set 3 : updates #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc#newcode4407 src/heap/heap.cc:4407: if (isolate()->concurrent_recompilation_enabled()) { Why is the flushing guarded by the potential garbage condition? Why don't we always flush on memory pressure?
On 2016/07/13 at 14:53:41, hpayer wrote: > https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc > File src/heap/heap.cc (right): > > https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc#newcode4407 > src/heap/heap.cc:4407: if (isolate()->concurrent_recompilation_enabled()) { > Why is the flushing guarded by the potential garbage condition? Why don't we always flush on memory pressure? that was my first intention, however, we only flush during CollectAllAvailableGarbage, so I thought I'd restrict it a bit more. I also wonder whether we should disable queuing new jobs while the memory pressure is critical..
On 2016/07/13 14:54:57, jochen wrote: > On 2016/07/13 at 14:53:41, hpayer wrote: > > https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc > > File src/heap/heap.cc (right): > > > > https://codereview.chromium.org/2145683003/diff/1/src/heap/heap.cc#newcode4407 > > src/heap/heap.cc:4407: if (isolate()->concurrent_recompilation_enabled()) { > > Why is the flushing guarded by the potential garbage condition? Why don't we > always flush on memory pressure? > > that was my first intention, however, we only flush during > CollectAllAvailableGarbage, so I thought I'd restrict it a bit more. +1 to flushing always on memory pressure. > I also wonder whether we should disable queuing new jobs while the memory > pressure is critical.. Considering that zone memory can be large, we could go further and not optimize at all while there is memory pressure.
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2145683003/#ps40001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Flush the optimizing compilejob queue when doing memory pressure GCs R=ulan@chromium.org,hpayer@chromium.org BUG= ========== to ========== Flush the optimizing compilejob queue when doing memory pressure GCs R=ulan@chromium.org,hpayer@chromium.org BUG= Committed: https://crrev.com/906cb204d069de8d1a27f2039d0c1c1509a6ad89 Cr-Commit-Position: refs/heads/master@{#37726} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/906cb204d069de8d1a27f2039d0c1c1509a6ad89 Cr-Commit-Position: refs/heads/master@{#37726} |
