Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: src/gpu/GrDrawTarget.cpp

Issue 2145643003: Move GrDrawTarget::clear logic into GrDrawContext (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix typo Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrDrawTarget.h ('k') | src/gpu/batches/GrClearBatch.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawTarget.cpp
diff --git a/src/gpu/GrDrawTarget.cpp b/src/gpu/GrDrawTarget.cpp
index bffe2f9740958fa0ad94f0774edd6bd45818a4aa..252726c710f565b2d2ec81203a4ae895f7ab6168 100644
--- a/src/gpu/GrDrawTarget.cpp
+++ b/src/gpu/GrDrawTarget.cpp
@@ -25,7 +25,7 @@
#include "SkStrokeRec.h"
-#include "batches/GrClearBatch.h"
+#include "batches/GrClearStencilClipBatch.h"
#include "batches/GrCopySurfaceBatch.h"
#include "batches/GrDiscardBatch.h"
#include "batches/GrDrawBatch.h"
@@ -443,44 +443,8 @@ void GrDrawTarget::stencilPath(const GrPipelineBuilder& pipelineBuilder,
batch->unref();
}
-void GrDrawTarget::clear(const SkIRect* rect,
- GrColor color,
- bool canIgnoreRect,
- GrDrawContext* drawContext) {
- SkIRect rtRect = SkIRect::MakeWH(drawContext->width(), drawContext->height());
- SkIRect clippedRect;
- if (!rect ||
- (canIgnoreRect && this->caps()->fullClearIsFree()) ||
- rect->contains(rtRect)) {
- rect = &rtRect;
- } else {
- clippedRect = *rect;
- if (!clippedRect.intersect(rtRect)) {
- return;
- }
- rect = &clippedRect;
- }
-
- if (this->caps()->useDrawInsteadOfClear()) {
- // This works around a driver bug with clear by drawing a rect instead.
- // The driver will ignore a clear if it is the only thing rendered to a
- // target before the target is read.
- if (rect == &rtRect) {
- drawContext->discard();
- }
-
- SkRect scalarRect = SkRect::Make(*rect);
-
- GrPaint paint;
- paint.setColor4f(GrColor4f::FromGrColor(color));
- paint.setXPFactory(GrPorterDuffXPFactory::Make(SkXfermode::kSrc_Mode));
-
- drawContext->drawRect(GrNoClip(), paint, SkMatrix::I(), scalarRect);
- } else {
- GrBatch* batch = new GrClearBatch(*rect, color, drawContext->accessRenderTarget());
- this->recordBatch(batch, batch->bounds());
- batch->unref();
- }
+void GrDrawTarget::addBatch(sk_sp<GrBatch> batch) {
+ this->recordBatch(batch.get(), batch->bounds());
}
void GrDrawTarget::discard(GrRenderTarget* renderTarget) {
« no previous file with comments | « src/gpu/GrDrawTarget.h ('k') | src/gpu/batches/GrClearBatch.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698