Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2145643002: Purge UnspecifiedBoolType from Blink. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, Mikhail, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge UnspecifiedBoolType from Blink. The modern pattern is "explicit operator bool". std::unique_ptr and WTF::RefPtr already do this, so this just pushes out to the remaining uses, except for one in WTF::String, which exists to conflict with operator NSString* on Mac and prevent boolean conversion via that (implicitly). Committed: https://crrev.com/f47b411ebf78e4215a7313a5d8535377753446ac Cr-Commit-Position: refs/heads/master@{#405013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Nullable.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/RetainPtr.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/wtf/WeakPtr.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbroman
Not important, but pushing this cleanup through. Should have no performance impact (though bug 605080 ...
4 years, 5 months ago (2016-07-12 20:11:18 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-07-13 00:05:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145643002/1
4 years, 5 months ago (2016-07-13 01:04:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 04:20:37 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:23:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f47b411ebf78e4215a7313a5d8535377753446ac
Cr-Commit-Position: refs/heads/master@{#405013}

Powered by Google App Engine
This is Rietveld 408576698