third_party/WebKit/Source/wtf/RetainPtr.h - Issue 2145643002: Purge UnspecifiedBoolType from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/RetainPtr.h

Issue 2145643002: Purge UnspecifiedBoolType from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/RetainPtr.h

diff --git a/third_party/WebKit/Source/wtf/RetainPtr.h b/third_party/WebKit/Source/wtf/RetainPtr.h

index 56c155a73ea918ddcd0b59d761726348f81a8044..4528231ae6335031127a41c2199357c9fe00c70b 100644

--- a/third_party/WebKit/Source/wtf/RetainPtr.h

+++ b/third_party/WebKit/Source/wtf/RetainPtr.h

@@ -106,11 +106,7 @@ public:

PtrType operator->() const { return m_ptr; }

bool operator!() const { return !m_ptr; }

- // This conversion operator allows implicit conversion to bool but not to

- // other integer types.

- typedef PtrType RetainPtr::*UnspecifiedBoolType;

- operator UnspecifiedBoolType() const { return m_ptr ? &RetainPtr::m_ptr : 0; }

+ explicit operator bool() const { return m_ptr; }

RetainPtr& operator=(const RetainPtr&);

template <typename U> RetainPtr& operator=(const RetainPtr<U>&);