Add ContentSuggestionsService to SnippetsInternals

chrome/browser/resources/snippets_internals.html

Index: chrome/browser/resources/snippets_internals.html
diff --git a/chrome/browser/resources/snippets_internals.html b/chrome/browser/resources/snippets_internals.html
index 0f8fdfc340c5697720b43f93d4fa22ac7caee790..68874eb5e8c7749d9ebc20585b8d25a7c0844821 100644
--- a/chrome/browser/resources/snippets_internals.html
+++ b/chrome/browser/resources/snippets_internals.html
@@ -37,11 +37,13 @@ found in the LICENSE file.
   </div>
 
   <div id="snippets">
-    <h2>Snippets <span class="detail">(click for details)</span></h2>
+    <h2>Snippets directly from NTPSnippetsService
+      <span class="detail">(click for details)</span>
+    </h2>
     <table class="section-details">
       <tr jsselect="list" style="display:none">
         <td class="title-link">
-          <span class="snippet-title" jsvalues="snippet-id:id">
+          <span class="snippet-title" jsvalues="hidden-id:id">
               <span jscontent="title"></span>&gt;&gt;</span>
           <div jsvalues="id:id" class="snippet-detail hidden">
             <table>
@@ -106,7 +108,7 @@ found in the LICENSE file.
     <table class="section-details">
       <tr jsselect="list" style="display:none">
         <td class="title-link">
-          <span class="discarded-snippet-title" jsvalues="snippet-id:id">
+          <span class="discarded-snippet-title" jsvalues="hidden-id:id">
               <span jscontent="title"></span> &gt;&gt;</span>
           <div jsvalues="id:id" class="snippet-detail hidden">
             <table>
@@ -149,4 +151,58 @@ found in the LICENSE file.
     </table>
     <div class="detail" id="hosts-empty"></div>
   </div>
+  
+  <div id="content-suggestions">
+    <h2>Content suggestions by category
+      <span class="detail">(click for details)</span>
+    </h2>
+    <div jsselect="list" style="display:none">
+      <h3>
+        <span jscontent="name"></span>
+        <span class="detail">
+          (<span jscontent="status"></span>)
+        </span>
+      </h3>
+      
+      <table class="section-details">
+        <tr jsselect="suggestions" style="display:none">
+          <td class="title-link">
+            <span class="content-suggestion-title"
+                jsvalues="hidden-id:id">
+              <span jscontent="title"></span>&gt;&gt;</span>

[Bernhard Bauer, 2016/07/12 14:44:51]

Move the last closing tag to a new line so it align the with opening one?

[Philipp Keck, 2016/07/12 15:19:56]

Good idea. I get confused by this HTML style where you leave out some closing
tags. Why does Chromium do that?

[Bernhard Bauer, 2016/07/12 15:50:31]

Because HTML5 doesn't require closing tags for certain kinds of tags, so this
way we minimize the HTML. This is rather new though -- I think jkrcal@ was the
one who introduced that style.

[Philipp Keck, 2016/07/12 16:05:37]

So minimize HTML to reduce the binary size? Removing unnecessary whitespace and
quotes could also be a good idea, but wouldn't you rather have a compiler do all
of that and write the code in the way you like to read it?

[Bernhard Bauer, 2016/07/12 16:16:27]

Coincidentally, aberent@ is working on exactly that. But I think that leaving
out the closing tags is in fact quite readable (assuming that the indentation is
correct, but that should be the case anyway).

[jkrcal, 2016/07/13 11:35:23]

Indeed, minimizing the code was not my primary goal. My primary goal was getting
used to the new html5 world :)

+            <div jsvalues="id:id" class="content-suggestion-detail hidden">
+              <table>
+                <tr>
+                  <td>ID
+                  <td jscontent="suggestionId">
+                <tr>
+                  <td>URL
+                  <td><a class="url" jsvalues="href:url" jscontent="url"></a>
+                <tr>
+                  <td>AMP URL
+                  <td>
+                    <a class="amp-url" jsvalues="href:ampUrl" 
+                        jscontent="ampUrl"></a>
+                <tr>
+                  <td>Snippet text
+                  <td jscontent="snippetText">
+                <tr>
+                  <td>Publish date
+                  <td class="expiry">
+                    <span class="date" jscontent="publishDate"></span>
+                <tr>
+                  <td>Publisher name
+                  <td jscontent="publisherName">
+              </table>
+            </div>
+      </table>
+    </div>
+    <div class="detail" id="content-suggestions-empty"></div>
+    <div class="forms">
+      <input id="submit-clear-cached-suggestions" type="submit"
+          value="Clear cached suggestions">
+      <input id="submit-clear-discarded-suggestions" type="submit"
+          value="Clear discarded suggestions">
+    </div>
+  </div>
 </div>