chrome/browser/resources/snippets_internals.html - Issue 2145563002: Add ContentSuggestionsService to SnippetsInternals

Side by Side Diff: chrome/browser/resources/snippets_internals.html

Issue 2145563002: Add ContentSuggestionsService to SnippetsInternals (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@articleprovider2

Patch Set: Bernhard's and Marc's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!--	1 <!--

2 Copyright 2016 The Chromium Authors. All rights reserved.	2 Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <!DOCTYPE html>	6 <!DOCTYPE html>

7 <meta charset="utf-8">	7 <meta charset="utf-8">

8 <if expr="is_android or is_ios">	8 <if expr="is_android or is_ios">

9 <meta name="viewport" content="width=device-width, initial-scale=1.0,	9 <meta name="viewport" content="width=device-width, initial-scale=1.0,

10 maximum-scale=1.0, user-scalable=no">	10 maximum-scale=1.0, user-scalable=no">

(...skipping 19 matching lines...) Expand all Loading...
30 <tr>	30 <tr>

31 <td class="name">Snippets type	31 <td class="name">Snippets type

32 <td id="switch-personalized" class="value">	32 <td id="switch-personalized" class="value">

33 <tr>	33 <tr>

34 <td class="name">Snippets fetch URL	34 <td class="name">Snippets fetch URL

35 <td id="switch-fetch-url" class="value">	35 <td id="switch-fetch-url" class="value">

36 </table>	36 </table>

37 </div>	37 </div>

38	38

39 <div id="snippets">	39 <div id="snippets">

40 <h2>Snippets <span class="detail">(click for details)</span></h2>	40 <h2>Snippets directly from NTPSnippetsService

	41 <span class="detail">(click for details)</span>

	42 </h2>

41 <table class="section-details">	43 <table class="section-details">

42 <tr jsselect="list" style="display:none">	44 <tr jsselect="list" style="display:none">

43 <td class="title-link">	45 <td class="title-link">

44 <span class="snippet-title" jsvalues="snippet-id:id">	46 <span class="snippet-title" jsvalues="hidden-id:id">

45 <span jscontent="title"></span>>></span>	47 <span jscontent="title"></span>>></span>

46 <div jsvalues="id:id" class="snippet-detail hidden">	48 <div jsvalues="id:id" class="snippet-detail hidden">

47 <table>	49 <table>

48 <tr>	50 <tr>

49 <td>ID	51 <td>ID

50 <td jscontent="snippetId">	52 <td jscontent="snippetId">

51 <tr>	53 <tr>

52 <td>Validity	54 <td>Validity

53 <td class="expiry">	55 <td class="expiry">

54 <span class="date" jscontent="published"></span> –	56 <span class="date" jscontent="published"></span> –

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
99 <div id="last-json-text"></div>	101 <div id="last-json-text"></div>

100 <input id="last-json-dump" type="submit" value="Dump the last JSON">	102 <input id="last-json-dump" type="submit" value="Dump the last JSON">

101 </div>	103 </div>

102 </div>	104 </div>

103	105

104 <div id="discarded-snippets">	106 <div id="discarded-snippets">

105 <h2>Discarded snippets <span class="detail">(click for details)</span></h2>	107 <h2>Discarded snippets <span class="detail">(click for details)</span></h2>

106 <table class="section-details">	108 <table class="section-details">

107 <tr jsselect="list" style="display:none">	109 <tr jsselect="list" style="display:none">

108 <td class="title-link">	110 <td class="title-link">

109 <span class="discarded-snippet-title" jsvalues="snippet-id:id">	111 <span class="discarded-snippet-title" jsvalues="hidden-id:id">

110 <span jscontent="title"></span> >></span>	112 <span jscontent="title"></span> >></span>

111 <div jsvalues="id:id" class="snippet-detail hidden">	113 <div jsvalues="id:id" class="snippet-detail hidden">

112 <table>	114 <table>

113 <tr>	115 <tr>

114 <td>Validity	116 <td>Validity

115 <td class="expiry">	117 <td class="expiry">

116 <span class="date" jscontent="published"></span> –	118 <span class="date" jscontent="published"></span> –

117 <span class="date" jscontent="expires"></span>	119 <span class="date" jscontent="expires"></span>

118 <tr>	120 <tr>

119 <td>Site title	121 <td>Site title

(...skipping 22 matching lines...) Expand all Loading...
142 </div>	144 </div>

143	145

144 <div id="hosts">	146 <div id="hosts">

145 <h2>Suggestion hosts</h2>	147 <h2>Suggestion hosts</h2>

146 <table class="section-details">	148 <table class="section-details">

147 <tr jsselect="list">	149 <tr jsselect="list">

148 <td jscontent="url">	150 <td jscontent="url">

149 </table>	151 </table>

150 <div class="detail" id="hosts-empty"></div>	152 <div class="detail" id="hosts-empty"></div>

151 </div>	153 </div>

	154

	155 <div id="content-suggestions">

	156 <h2>Content suggestions by category

	157 <span class="detail">(click for details)</span>

	158 </h2>

	159 <div jsselect="list" style="display:none">

	160 <h3>

	161 <span jscontent="name"></span>

	162 <span class="detail">

	163 (<span jscontent="status"></span>)

	164 </span>

	165 </h3>

	166

	167 <table class="section-details">

	168 <tr jsselect="suggestions" style="display:none">

	169 <td class="title-link">

	170 <span class="content-suggestion-title"

	171 jsvalues="hidden-id:id">

	172 <span jscontent="title"></span>>></span>
	Bernhard Bauer 2016/07/12 14:44:51 Move the last closing tag to a new line so it alig Move the last closing tag to a new line so it align the with opening one? Philipp Keck 2016/07/12 15:19:56 Good idea. I get confused by this HTML style where Show quoted text On 2016/07/12 14:44:51, Bernhard Bauer wrote: > Move the last closing tag to a new line so it align the with opening one? Good idea. I get confused by this HTML style where you leave out some closing tags. Why does Chromium do that? Bernhard Bauer 2016/07/12 15:50:31 Because HTML5 doesn't require closing tags for cer Show quoted text On 2016/07/12 15:19:56, Philipp Keck wrote: > On 2016/07/12 14:44:51, Bernhard Bauer wrote: > > Move the last closing tag to a new line so it align the with opening one? > > Good idea. I get confused by this HTML style where you leave out some closing > tags. Why does Chromium do that? Because HTML5 doesn't require closing tags for certain kinds of tags, so this way we minimize the HTML. This is rather new though -- I think jkrcal@ was the one who introduced that style. Philipp Keck 2016/07/12 16:05:37 So minimize HTML to reduce the binary size? Removi Show quoted text On 2016/07/12 15:50:31, Bernhard Bauer wrote: > On 2016/07/12 15:19:56, Philipp Keck wrote: > > On 2016/07/12 14:44:51, Bernhard Bauer wrote: > > > Move the last closing tag to a new line so it align the with opening one? > > > > Good idea. I get confused by this HTML style where you leave out some closing > > tags. Why does Chromium do that? > > Because HTML5 doesn't require closing tags for certain kinds of tags, so this > way we minimize the HTML. This is rather new though -- I think jkrcal@ was the > one who introduced that style. So minimize HTML to reduce the binary size? Removing unnecessary whitespace and quotes could also be a good idea, but wouldn't you rather have a compiler do all of that and write the code in the way you like to read it? Bernhard Bauer 2016/07/12 16:16:27 Coincidentally, aberent@ is working on exactly tha Show quoted text On 2016/07/12 16:05:37, Philipp Keck wrote: > On 2016/07/12 15:50:31, Bernhard Bauer wrote: > > On 2016/07/12 15:19:56, Philipp Keck wrote: > > > On 2016/07/12 14:44:51, Bernhard Bauer wrote: > > > > Move the last closing tag to a new line so it align the with opening one? > > > > > > Good idea. I get confused by this HTML style where you leave out some > closing > > > tags. Why does Chromium do that? > > > > Because HTML5 doesn't require closing tags for certain kinds of tags, so this > > way we minimize the HTML. This is rather new though -- I think jkrcal@ was the > > one who introduced that style. > > So minimize HTML to reduce the binary size? Removing unnecessary whitespace and > quotes could also be a good idea, but wouldn't you rather have a compiler do all > of that and write the code in the way you like to read it? Coincidentally, aberent@ is working on exactly that. But I think that leaving out the closing tags is in fact quite readable (assuming that the indentation is correct, but that should be the case anyway). jkrcal 2016/07/13 11:35:23 Indeed, minimizing the code was not my primary goa Show quoted text On 2016/07/12 16:16:27, Bernhard Bauer wrote: > On 2016/07/12 16:05:37, Philipp Keck wrote: > > On 2016/07/12 15:50:31, Bernhard Bauer wrote: > > > On 2016/07/12 15:19:56, Philipp Keck wrote: > > > > On 2016/07/12 14:44:51, Bernhard Bauer wrote: > > > > > Move the last closing tag to a new line so it align the with opening > one? > > > > > > > > Good idea. I get confused by this HTML style where you leave out some > > closing > > > > tags. Why does Chromium do that? > > > > > > Because HTML5 doesn't require closing tags for certain kinds of tags, so > this > > > way we minimize the HTML. This is rather new though -- I think jkrcal@ was > the > > > one who introduced that style. > > > > So minimize HTML to reduce the binary size? Removing unnecessary whitespace > and > > quotes could also be a good idea, but wouldn't you rather have a compiler do > all > > of that and write the code in the way you like to read it? > > Coincidentally, aberent@ is working on exactly that. But I think that leaving > out the closing tags is in fact quite readable (assuming that the indentation is > correct, but that should be the case anyway). Indeed, minimizing the code was not my primary goal. My primary goal was getting used to the new html5 world :)
	173 <div jsvalues="id:id" class="content-suggestion-detail hidden">

	174 <table>

	175 <tr>

	176 <td>ID

	177 <td jscontent="suggestionId">

	178 <tr>

	179 <td>URL

	180 <td><a class="url" jsvalues="href:url" jscontent="url"></a>

	181 <tr>

	182 <td>AMP URL

	183 <td>

	184 <a class="amp-url" jsvalues="href:ampUrl"

	185 jscontent="ampUrl"></a>

	186 <tr>

	187 <td>Snippet text

	188 <td jscontent="snippetText">

	189 <tr>

	190 <td>Publish date

	191 <td class="expiry">

	192 <span class="date" jscontent="publishDate"></span>

	193 <tr>

	194 <td>Publisher name

	195 <td jscontent="publisherName">

	196 </table>

	197 </div>

	198 </table>

	199 </div>

	200 <div class="detail" id="content-suggestions-empty"></div>

	201 <div class="forms">

	202 <input id="submit-clear-cached-suggestions" type="submit"

	203 value="Clear cached suggestions">

	204 <input id="submit-clear-discarded-suggestions" type="submit"

	205 value="Clear discarded suggestions">

	206 </div>

	207 </div>

152 </div>	208 </div>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/resources/snippets_internals.js » ('j') | chrome/browser/ui/webui/snippets_internals_message_handler.cc » ('J')