Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2145543002: Use base::FooValue::From() to simplify gpu code. (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::FooValue::From() to simplify gpu code. Clean up compositor_model_bench code. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4c5b23ef49bf313e6dd636a6d0194798ced7b481 Cr-Commit-Position: refs/heads/master@{#405244}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -250 lines) Patch
M gpu/config/gpu_control_list.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 7 chunks +25 lines, -32 lines 0 comments Download
M gpu/tools/compositor_model_bench/forward_render_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/tools/compositor_model_bench/forward_render_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_models.h View 1 chunk +7 lines, -5 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_models.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M gpu/tools/compositor_model_bench/render_tree.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/render_tree.cc View 8 chunks +184 lines, -188 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
4 years, 5 months ago (2016-07-13 16:15:43 UTC) #4
piman
lgtm
4 years, 5 months ago (2016-07-13 18:49:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145543002/20001
4 years, 5 months ago (2016-07-13 18:54:23 UTC) #7
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names without "master." prefix is ...
4 years, 5 months ago (2016-07-13 19:33:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 19:57:06 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:00:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c5b23ef49bf313e6dd636a6d0194798ced7b481
Cr-Commit-Position: refs/heads/master@{#405244}

Powered by Google App Engine
This is Rietveld 408576698