Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2145383002:
Pass weak pointer by ref in Bind implementation (Closed)
|
Created:
4 years, 5 months ago by tzik Modified:
4 years, 5 months ago Reviewers:
Yuta Kitamura CC:
chromium-reviews, sof Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPass weak pointer by ref in Bind implementation
Weak pointer in Bind impl is historically passed by value, however when
a blink::WeakPersistent is passed as a receiver of a method after
blink::ThreadState is destroyed, it can no longer be copied and causes
crash.
BUG=627820
Committed: https://crrev.com/33871d83b7ee98a1aa5692f8f835d44b7da65ef5
Cr-Commit-Position: refs/heads/master@{#405475}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 ========== to ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 ==========
tzik@chromium.org changed reviewers: + yutak@chromium.org
PTAL
lgtm
The CQ bit was unchecked by tzik@chromium.org
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 ========== to ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 ========== to ========== Pass weak pointer by ref in Bind implementation Weak pointer in Bind impl is historically passed by value, however when a blink::WeakPersistent is passed as a receiver of a method after blink::ThreadState is destroyed, it can no longer be copied and causes crash. BUG=627820 Committed: https://crrev.com/33871d83b7ee98a1aa5692f8f835d44b7da65ef5 Cr-Commit-Position: refs/heads/master@{#405475} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/33871d83b7ee98a1aa5692f8f835d44b7da65ef5 Cr-Commit-Position: refs/heads/master@{#405475} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
