base/bind_internal.h - Issue 2145383002: Pass weak pointer by ref in Bind implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/bind_internal.h

Issue 2145383002: Pass weak pointer by ref in Bind implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/bind_internal.h

diff --git a/base/bind_internal.h b/base/bind_internal.h

index e3ccb25d5ecbe9b9aa6635df309826c9a31f7b60..3d6ca09c41e4e31404a11bb16ad99a425bc6369c 100644

--- a/base/bind_internal.h

+++ b/base/bind_internal.h

@@ -295,7 +295,7 @@ struct InvokeHelper<true, ReturnType> {

template <typename Functor, typename BoundWeakPtr, typename... RunArgs>

static inline void MakeItSo(Functor&& functor,

- BoundWeakPtr weak_ptr,

+ BoundWeakPtr&& weak_ptr,

RunArgs&&... args) {

if (!weak_ptr)

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »