Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2145373002: Revert of Add hooks to permission layer for permission action reporting (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add hooks to permission layer for permission action reporting (patchset #27 id:520001 of https://codereview.chromium.org/2047253002/ ) Reason for revert: Modifying the global command line breaks other tests. Original issue's description: > Add hooks to permission layer for permission action reporting > - permissions_reporter_ added to SafeBrowsingPingManager > - Permission user actions collected by PermissionUmaUtil > > Reports are only sent to opted-in users (Safe Browsing AND Chrome Tab Sync AND Chrome Pref Sync) > > Only origin, permission type, and permission action are collected. > > Data collected are from PROMPT source UI only. > > BUG=613883 > > Committed: https://crrev.com/41b6de326ed85f2672e8d38720c140dbafa0862e > Cr-Commit-Position: refs/heads/master@{#405051} TBR=kcarattini@chromium.org,raymes@chromium.org,nparker@chromium.org,pavely@chromium.org,sergeyu@chromium.org,johnme@chromium.org,stefanocs@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=613883 Committed: https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b Cr-Commit-Position: refs/heads/master@{#405465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -433 lines) Patch
M chrome/browser/media/media_stream_devices_controller.cc View 6 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/permissions/permission_bubble_request_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_infobar_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/permissions/permission_queue_controller.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.h View 2 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util.cc View 4 chunks +103 lines, -147 lines 0 comments Download
D chrome/browser/permissions/permission_uma_util_unittest.cc View 1 chunk +0 lines, -161 lines 0 comments Download
M chrome/browser/permissions/permission_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager.h View 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/ping_manager.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.h View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Created Revert of Add hooks to permission layer for permission action reporting
4 years, 5 months ago (2016-07-14 09:15:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145373002/1
4 years, 5 months ago (2016-07-14 09:15:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 10:36:26 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 10:36:28 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 10:37:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1cd8f6ccd4a33e7093c5940f5091a80b4a2206b
Cr-Commit-Position: refs/heads/master@{#405465}

Powered by Google App Engine
This is Rietveld 408576698