Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/permissions/permission_uma_util_unittest.cc

Issue 2145373002: Revert of Add hooks to permission layer for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-reporter-implementation
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/permissions/permission_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util_unittest.cc
diff --git a/chrome/browser/permissions/permission_uma_util_unittest.cc b/chrome/browser/permissions/permission_uma_util_unittest.cc
deleted file mode 100644
index 4921fceb516aba2f9703aefde1f11a2dcd3efa8b..0000000000000000000000000000000000000000
--- a/chrome/browser/permissions/permission_uma_util_unittest.cc
+++ /dev/null
@@ -1,161 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/permissions/permission_uma_util.h"
-
-#include "base/command_line.h"
-#include "chrome/browser/signin/fake_signin_manager_builder.h"
-#include "chrome/browser/signin/signin_manager_factory.h"
-#include "chrome/browser/sync/profile_sync_service_factory.h"
-#include "chrome/common/chrome_switches.h"
-#include "chrome/common/pref_names.h"
-#include "chrome/test/base/testing_profile.h"
-#include "components/browser_sync/browser/profile_sync_service.h"
-#include "components/browser_sync/common/browser_sync_switches.h"
-#include "components/prefs/pref_service.h"
-#include "components/sync_driver/glue/sync_backend_host_mock.h"
-#include "content/public/test/test_browser_thread_bundle.h"
-#include "sync/internal_api/public/base/model_type.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace {
-const char* kTestingGaiaId = "gaia_id";
-const char* kTestingUsername = "fake_username";
-} // namespace
-
-class PermissionUmaUtilTest : public testing::Test {
- protected:
- PermissionUmaUtilTest() : profile_(new TestingProfile()) {}
-
- static bool IsOptedIntoPermissionActionReporting(Profile* profile) {
- return PermissionUmaUtil::IsOptedIntoPermissionActionReporting(profile);
- }
-
- void SetUp() override {
- profile_.reset(new TestingProfile());
- ResetCommandLine();
- }
-
- void FakeSignIn() {
- SigninManagerBase* signin_manager =
- static_cast<FakeSigninManagerForTesting*>(
- SigninManagerFactory::GetForProfile(profile()));
- signin_manager->SetAuthenticatedAccountInfo(kTestingGaiaId,
- kTestingUsername);
- // Attach a sync backend to the profile sync service.
- GetProfileSyncService()->backend_.reset(
- new browser_sync::SyncBackendHostMock());
- GetProfileSyncService()->backend_initialized_ = true;
- }
-
- void ResetCommandLine() {
- base::CommandLine::Reset();
- base::CommandLine::Init(0, NULL);
- }
-
- void SetKeepEverythingSynced(bool flag) {
- GetProfileSyncService()->sync_prefs_.SetKeepEverythingSynced(flag);
- }
-
- void SetSafeBrowsing(bool enabled) {
- PrefService* preferences = profile_->GetPrefs();
- preferences->SetBoolean(prefs::kSafeBrowsingEnabled, enabled);
- }
-
- ProfileSyncService* GetProfileSyncService() {
- return ProfileSyncServiceFactory::GetForProfile(profile());
- }
-
- Profile* profile() { return profile_.get(); }
-
- private:
- content::TestBrowserThreadBundle thread_bundle_;
- std::unique_ptr<Profile> profile_;
-};
-
-// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
-// true if Safe Browsing is enabled, Permission Action Reporting flag is
-// enabled, not in incognito mode and signed in with default sync preferences.
-TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingSignInCheck) {
- SetSafeBrowsing(true);
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnablePermissionActionReporting);
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-
- FakeSignIn();
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(
- profile()->GetOffTheRecordProfile()));
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-}
-
-// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
-// false if Permission Action Reporting is not enabled.
-TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingFlagCheck) {
- SetSafeBrowsing(true);
- FakeSignIn();
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnablePermissionActionReporting);
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-
- ResetCommandLine();
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kDisablePermissionActionReporting);
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-}
-
-// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
-// false if Safe Browsing is disabled.
-TEST_F(PermissionUmaUtilTest,
- IsOptedIntoPermissionActionReportingSafeBrowsingCheck) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnablePermissionActionReporting);
- FakeSignIn();
- SetSafeBrowsing(true);
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-
- SetSafeBrowsing(false);
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-}
-
-// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
-// false if Sync is disabled.
-TEST_F(PermissionUmaUtilTest,
- IsOptedIntoPermissionActionReportingProfileSyncServiceCheck) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnablePermissionActionReporting);
- SetSafeBrowsing(true);
- FakeSignIn();
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-
- base::CommandLine::ForCurrentProcess()->AppendSwitch(switches::kDisableSync);
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-}
-
-// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
-// false if Tab Sync and Pref Sync are not both enabled.
-TEST_F(PermissionUmaUtilTest,
- IsOptedIntoPermissionActionReportingSyncPreferenceCheck) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnablePermissionActionReporting);
- SetSafeBrowsing(true);
- FakeSignIn();
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-
- SetKeepEverythingSynced(false);
- GetProfileSyncService()->ChangePreferredDataTypes(
- syncer::ModelTypeSet(syncer::PROXY_TABS));
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-
- SetKeepEverythingSynced(false);
- GetProfileSyncService()->ChangePreferredDataTypes(
- syncer::ModelTypeSet(syncer::PRIORITY_PREFERENCES));
- EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
-
- SetKeepEverythingSynced(true);
- GetProfileSyncService()->ChangePreferredDataTypes(
- syncer::ModelTypeSet(syncer::PROXY_TABS, syncer::PREFERENCES));
- EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
-}
« no previous file with comments | « chrome/browser/permissions/permission_uma_util.cc ('k') | chrome/browser/permissions/permission_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698