Remove unnecessary top()->document() null check from PluginListChanged.

Remove unnecessary top()->document() null check from PluginListChanged.

This was introduced in r135340 in an attempt to fix a crash in issue
125969, which it ended up not fixing, but nobody reverted it
afterward.  It doesn't appear to be necessary.

BUG=466297
Committed: https://crrev.com/9a08b8c69ce158d0f2ad5fae0ec1ed43ff021b99
Cr-Commit-Position: refs/heads/master@{#406005}

[alexmos, 2016-07-15 21:23:35]

The CQ bit was checked by alexmos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 21:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alexmos, 2016-07-15 22:16:03]

alexmos@chromium.org changed reviewers:
+ jochen@chromium.org

[alexmos, 2016-07-15 22:16:04]

Jochen, can you please take a look?

I'm trying to clean up the last few placed using top()->document(), which is
incompatible with OOPIFs, and noticed this.  As far as I can tell, this check
was introduced by bauerb@ in r135340 to try and fix a crash in
https://crbug.com/125969.  It didn't actually fix the crash, which was later
fixed by adding another null check for the frame, but nobody reverted this code.
 I don't see a good reason why we need it, especially given that the top
document isn't even used in this function anymore.  Do you agree?

[commit-bot: I haz the power, 2016-07-15 22:25:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:25:18]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-07-18 11:41:42]

jochen@chromium.org changed reviewers:
+ bauerb@chromium.org

[jochen (gone - plz use gerrit), 2016-07-18 11:41:43]

+bauerb ptal

[Bernhard Bauer, 2016-07-18 13:53:07]

Heh, yeah. https://crrev.com/125969#c5 describes my thinking at the time :-D

LGTM, thanks!

[jochen (gone - plz use gerrit), 2016-07-18 13:56:47]

lgtm

[alexmos, 2016-07-18 15:14:30]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2016-07-18 15:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 15:59:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-18 15:59:58]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 16:01:09]

Description was changed from

==========
Remove unnecessary top()->document() null check from PluginListChanged.

This was introduced in r135340 in an attempt to fix a crash in issue
125969, which it ended up not fixing, but nobody reverted it
afterward.  It doesn't appear to be necessary.

BUG=466297
==========

to

==========
Remove unnecessary top()->document() null check from PluginListChanged.

This was introduced in r135340 in an attempt to fix a crash in issue
125969, which it ended up not fixing, but nobody reverted it
afterward.  It doesn't appear to be necessary.

BUG=466297

Committed: https://crrev.com/9a08b8c69ce158d0f2ad5fae0ec1ed43ff021b99
Cr-Commit-Position: refs/heads/master@{#406005}
==========

[commit-bot: I haz the power, 2016-07-18 16:01:11]

Patchset 1 (id:??) landed as
https://crrev.com/9a08b8c69ce158d0f2ad5fae0ec1ed43ff021b99
Cr-Commit-Position: refs/heads/master@{#406005}