chrome/renderer/plugins/chrome_plugin_placeholder.cc - Issue 2145353004: Remove unnecessary top()->document() null check from PluginListChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.cc

Issue 2145353004: Remove unnecessary top()->document() null check from PluginListChanged. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/plugins/chrome_plugin_placeholder.cc

diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.cc b/chrome/renderer/plugins/chrome_plugin_placeholder.cc

index 575aeda7650705131a85049e139a019fa22be305..0f35197e27cbaacbde7c35fa4d943306f4e8f3fe 100644

--- a/chrome/renderer/plugins/chrome_plugin_placeholder.cc

+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.cc

@@ -260,9 +260,6 @@ void ChromePluginPlaceholder::OnCancelledDownloadingPlugin() {

void ChromePluginPlaceholder::PluginListChanged() {

if (!GetFrame() || !plugin())

return;

- blink::WebDocument document = GetFrame()->top()->document();

- if (document.isNull())

- return;

ChromeViewHostMsg_GetPluginInfo_Output output;

std::string mime_type(GetPluginParams().mimeType.utf8());

« no previous file with comments | « no previous file | no next file » | no next file with comments »