Recast draw_filter_into_device as drawDevice

Recast draw_filter_into_device as drawDevice

The SkCanvas-side changes can't land until all the drawDevice calls know how to deal with SkImageFilters

spawned:
https://codereview.chromium.org/2157513002/ (Add copy (when needed) to SkGpuDevice::asSpecial)
https://codereview.chromium.org/2162883002/ (Rename variables in SkCanvas::internalSaveLayer)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005

[robertphillips, 2016-07-15 15:47:26]

Description was changed from

==========
Recast draw_filter_into_device as drawDevice
==========

to

==========
Recast draw_filter_into_device as drawDevice
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

[robertphillips, 2016-07-15 15:48:52]

Description was changed from

==========
Recast draw_filter_into_device as drawDevice
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

to

==========
Recast draw_filter_into_device as drawDevice

The SkGpuDevice-side changes could land right now.
The SkCanvas-side changes can't land until all the drawDevice calls know how to
deal with SkImageFilters

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

[robertphillips, 2016-07-15 15:48:52]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[reed1, 2016-07-15 16:00:57]

https://codereview.chromium.org/2145343005/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/2145343005/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:1303: }
Can we move the "seed-the-new-top-device-pixels" code here?

[robertphillips, 2016-07-18 16:39:40]

https://codereview.chromium.org/2145343005/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/2145343005/diff/1/src/core/SkCanvas.cpp#newco...
src/core/SkCanvas.cpp:1303: }
On 2016/07/15 16:00:56, reed1 wrote:
> Can we move the "seed-the-new-top-device-pixels" code here?

Done.

[reed1, 2016-07-18 16:57:03]

lgtm

[robertphillips, 2016-07-19 12:10:04]

Description was changed from

==========
Recast draw_filter_into_device as drawDevice

The SkGpuDevice-side changes could land right now.
The SkCanvas-side changes can't land until all the drawDevice calls know how to
deal with SkImageFilters

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

to

==========
Recast draw_filter_into_device as drawDevice

The SkGpuDevice-side changes could land right now.
The SkCanvas-side changes can't land until all the drawDevice calls know how to
deal with SkImageFilters

spawned:
https://codereview.chromium.org/2162883002/ (Rename variables in
SkCanvas::internalSaveLayer)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

[robertphillips, 2016-07-19 12:12:02]

Description was changed from

==========
Recast draw_filter_into_device as drawDevice

The SkGpuDevice-side changes could land right now.
The SkCanvas-side changes can't land until all the drawDevice calls know how to
deal with SkImageFilters

spawned:
https://codereview.chromium.org/2162883002/ (Rename variables in
SkCanvas::internalSaveLayer)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

to

==========
Recast draw_filter_into_device as drawDevice

The SkCanvas-side changes can't land until all the drawDevice calls know how to
deal with SkImageFilters

spawned:
https://codereview.chromium.org/2157513002/ (Add copy (when needed) to
SkGpuDevice::asSpecial)
https://codereview.chromium.org/2162883002/ (Rename variables in
SkCanvas::internalSaveLayer)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2145343005
==========

[robertphillips, 2017-02-15 19:04:46]

This - or something very much like it - appears to have landed