Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows)

Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows)

Based on crbug.com/178296, the test was disabled for WinXP.
Since WinXP is no longer maintained, we can enable the test.

BUG=178296
Test=None

Committed: https://crrev.com/bc85854590fbd17b2639d017278659bac1dbf58e
Cr-Commit-Position: refs/heads/master@{#405523}

[lazyboy, 2016-07-14 06:21:51]

lazyboy@chromium.org changed reviewers:
+ asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-07-14 16:47:21]

lgtm

BTW, either the codereview tool is confused or you accidentally based this
branch off something other than origin/master, because it shows "Depends on
Patchset: Issue 885803002 Patch 60001"

To fix this I think you can just run:

git branch --set-upstream-to=origin/master
git merge origin/master
git cl upload

(not sure if the merge is necessary or not)

[lazyboy, 2016-07-14 17:05:14]

On 2016/07/14 16:47:21, Antony Sargent wrote:
> lgtm
> 
> BTW, either the codereview tool is confused or you accidentally based this
> branch off something other than origin/master, because it shows "Depends on
> Patchset: Issue 885803002 Patch 60001"
> 
> To fix this I think you can just run:
> 
> git branch --set-upstream-to=origin/master
> git merge origin/master
> git cl upload
> 
> (not sure if the merge is necessary or not)

I think this happens if I upload from my mac, I think it fixed
with --set-upstream-to, thanks.

[lazyboy, 2016-07-14 18:22:17]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2016-07-14 18:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2145343002/#ps20001
(title: "fix dependent patchset")

[commit-bot: I haz the power, 2016-07-14 18:23:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:41:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 18:41:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 18:43:53]

Description was changed from

==========
Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows)

Based on crbug.com/178296, the test was disabled for WinXP.
Since WinXP is no longer maintained, we can enable the test.

BUG=178296
Test=None
==========

to

==========
Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows)

Based on crbug.com/178296, the test was disabled for WinXP.
Since WinXP is no longer maintained, we can enable the test.

BUG=178296
Test=None

Committed: https://crrev.com/bc85854590fbd17b2639d017278659bac1dbf58e
Cr-Commit-Position: refs/heads/master@{#405523}
==========

[commit-bot: I haz the power, 2016-07-14 18:43:54]

Patchset 2 (id:??) landed as
https://crrev.com/bc85854590fbd17b2639d017278659bac1dbf58e
Cr-Commit-Position: refs/heads/master@{#405523}