chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 2145343002: Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 2145343002: Enable ExtensionWebRequestApiTest.WebRequestDeclarative2 (on Windows) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix dependent patchset Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 905f8cff3dc0f331ba9a7bd3593c9f0cc117a4db..20053730ff73db1fed2290432dcaafa570234e33 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -254,14 +254,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestDeclarative1) {

<< message_;

}

-// This test times out on XP. See http://crbug.com/178296

-#if defined(OS_WIN)

-#define MAYBE_WebRequestDeclarative2 DISABLED_WebRequestDeclarative2

-#else

-#define MAYBE_WebRequestDeclarative2 WebRequestDeclarative2

-#endif

-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

- MAYBE_WebRequestDeclarative2) {

+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestDeclarative2) {

ASSERT_TRUE(StartEmbeddedTestServer());

ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_declarative2.html"))

<< message_;

« no previous file with comments | « no previous file | no next file » | no next file with comments »