Make webkit_modules a split static library in non-component builds.

Make webkit_modules a split static library in non-component builds.

Previously this was force to a source set because it was too large for official Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows builds so it can be a static library now.

BUG=627637
Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
Cr-Commit-Position: refs/heads/master@{#405618}

[brettw, 2016-07-14 20:15:38]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-07-14 20:15:38]

This requires the GN roll in https://codereview.chromium.org/2149073003 to fix a
target() invocation bug.

[brucedawson, 2016-07-14 20:22:52]

Yes!

It would be interesting to measure build times and build sizes with and without
this. I can do some comparisons if you want.

lgtm

[brettw, 2016-07-14 20:28:46]

Dirk was just asking me about timings in some of the other conversions I did.
The answer is that I'm not really worrying about it. It seems beneficial to
change the stuff that can be changed. If when the obvious stuff is done we still
have a noticeable problem, we can do a more careful analysis.

Of course if you want to run some numbers on this patch, please do so!

[brettw, 2016-07-14 21:32:15]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-14 21:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:08:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-14 23:09:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 23:11:30]

Description was changed from

==========
Make webkit_modules a split static library in non-component builds.

Previously this was force to a source set because it was too large for official
Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.

BUG=627637
==========

to

==========
Make webkit_modules a split static library in non-component builds.

Previously this was force to a source set because it was too large for official
Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows
builds so it can be a static library now.

BUG=627637

Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
Cr-Commit-Position: refs/heads/master@{#405618}
==========

[commit-bot: I haz the power, 2016-07-14 23:11:31]

Patchset 2 (id:??) landed as
https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
Cr-Commit-Position: refs/heads/master@{#405618}

[henrika (OOO until Aug 14), 2016-07-15 08:38:18]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2150003004/ by henrika@chromium.org.

The reason for reverting is: I suspect that this change can cause failure in the
generate_build_files step on Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chro....