Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2145243003: Revert of Disable "taking address of packed member" clang warning. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable "taking address of packed member" clang warning. (patchset #2 id:60001 of https://codereview.chromium.org/2148283002/ ) Reason for revert: Warning was reverted upstream again. Original issue's description: > Reland of Disable "taking address of packed member" clang warning. (patchset #1 id:1 of https://codereview.chromium.org/2066503004/ ) > > Reason for revert: > The warning was relanded upstream this morning. > > Original issue's description: > > Revert of Disable "taking address of packed member" clang warning. (patchset #3 id:40001 of https://codereview.chromium.org/2059143003/ ) > > > > Reason for revert: > > The warning got reverted upstream. > > > > Original issue's description: > > > Disable "taking address of packed member" clang warning. > > > > > > Pending cleanup. > > > > > > BUG=619640 > > > > > > Committed: https://crrev.com/e77a373b7141f2e52f79f5cba5c2577fc16a4f5e > > > Cr-Commit-Position: refs/heads/master@{#399572} > > > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=619640 > > > > Committed: https://crrev.com/f999d8350f0fbdefac8875135ca3540c64d2f3f4 > > Cr-Commit-Position: refs/heads/master@{#399686} > > TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,thakis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=619640 > > Committed: https://crrev.com/805bf6aaa5de841e0cf987e0d7005f5abd7df54c > Cr-Commit-Position: refs/heads/master@{#405538} TBR=dpranke@chromium.org,hans@chromium.org,eugenis@google.com,eugenis@chromium.org,rnk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619640 Committed: https://crrev.com/9055c04e9973804ab9941b18f4b5efc18bfdbdc2 Cr-Commit-Position: refs/heads/master@{#405560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
Created Revert of Disable "taking address of packed member" clang warning.
4 years, 5 months ago (2016-07-14 20:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145243003/1
4 years, 5 months ago (2016-07-14 20:45:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 20:45:48 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 20:46:05 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9055c04e9973804ab9941b18f4b5efc18bfdbdc2 Cr-Commit-Position: refs/heads/master@{#405560}
4 years, 5 months ago (2016-07-14 20:49:54 UTC) #7
Dirk Pranke
4 years, 5 months ago (2016-07-14 20:52:13 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698