Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: build/common.gypi

Issue 2145243003: Revert of Disable "taking address of packed member" clang warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3013 matching lines...) Expand 10 before | Expand all | Expand 10 after
3024 'defines': [ 3024 'defines': [
3025 'ADDRESS_SANITIZER', 3025 'ADDRESS_SANITIZER',
3026 'MEMORY_TOOL_REPLACES_ALLOCATOR', 3026 'MEMORY_TOOL_REPLACES_ALLOCATOR',
3027 'MEMORY_SANITIZER_INITIAL_SIZE', 3027 'MEMORY_SANITIZER_INITIAL_SIZE',
3028 ], 3028 ],
3029 }], 3029 }],
3030 ['enable_wexit_time_destructors==1 and OS!="win"', { 3030 ['enable_wexit_time_destructors==1 and OS!="win"', {
3031 # TODO: Enable on Windows too, http://crbug.com/404525 3031 # TODO: Enable on Windows too, http://crbug.com/404525
3032 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']}, 3032 'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
3033 }], 3033 }],
3034 ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="2 74369-1"', {
3035 # TODO(eugenis): https://crbug.com/619640
3036 'variables': { 'clang_warning_flags': ['-Wno-address-of-packed-member']} ,
3037 }],
3038 ['chromium_code==0', { 3034 ['chromium_code==0', {
3039 'variables': { 3035 'variables': {
3040 'clang_warning_flags': [ 3036 'clang_warning_flags': [
3041 # Lots of third-party libraries have unused variables. Instead of 3037 # Lots of third-party libraries have unused variables. Instead of
3042 # suppressing them individually, we just blanket suppress them here. 3038 # suppressing them individually, we just blanket suppress them here.
3043 '-Wno-unused-variable', 3039 '-Wno-unused-variable',
3044 ], 3040 ],
3045 }, 3041 },
3046 'conditions': [ 3042 'conditions': [
3047 [ 'os_posix==1 and OS!="mac" and OS!="ios"', { 3043 [ 'os_posix==1 and OS!="mac" and OS!="ios"', {
(...skipping 3297 matching lines...) Expand 10 before | Expand all | Expand 10 after
6345 # settings in target dicts. SYMROOT is a special case, because many other 6341 # settings in target dicts. SYMROOT is a special case, because many other
6346 # Xcode variables depend on it, including variables such as 6342 # Xcode variables depend on it, including variables such as
6347 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6343 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6348 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6344 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6349 # files to appear (when present) in the UI as actual files and not red 6345 # files to appear (when present) in the UI as actual files and not red
6350 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6346 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6351 # and therefore SYMROOT, needs to be set at the project level. 6347 # and therefore SYMROOT, needs to be set at the project level.
6352 'SYMROOT': '<(DEPTH)/xcodebuild', 6348 'SYMROOT': '<(DEPTH)/xcodebuild',
6353 }, 6349 },
6354 } 6350 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698