Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2145023002: [builtins] move builtin files to src/builtins/. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] move builtin files to src/builtins/. R=bmeurer@chromium.org BUG=v8:5197 Committed: https://crrev.com/c8a0c0bdadbb79cc5e3cd50a59a4ef93a9a0d5b2 Cr-Commit-Position: refs/heads/master@{#37740}

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -36089 lines) Patch
M BUILD.gn View 1 2 3 15 chunks +9 lines, -9 lines 0 comments Download
D src/arm/builtins-arm.cc View 1 2 3 1 chunk +0 lines, -2988 lines 0 comments Download
D src/arm64/builtins-arm64.cc View 1 2 3 1 chunk +0 lines, -3106 lines 0 comments Download
M src/assembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/ast.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D src/builtins.h View 1 2 3 1 chunk +0 lines, -852 lines 0 comments Download
D src/builtins.cc View 1 2 3 1 chunk +0 lines, -6804 lines 0 comments Download
A + src/builtins/arm/builtins-arm.cc View 1 2 3 44 chunks +22 lines, -71 lines 0 comments Download
A + src/builtins/arm64/builtins-arm64.cc View 1 2 3 46 chunks +26 lines, -75 lines 0 comments Download
A + src/builtins/builtins.h View 1 2 3 7 chunks +26 lines, -29 lines 0 comments Download
A + src/builtins/builtins.cc View 1 2 3 101 chunks +24 lines, -157 lines 0 comments Download
A + src/builtins/ia32/builtins-ia32.cc View 1 2 3 36 chunks +13 lines, -59 lines 0 comments Download
A + src/builtins/mips/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/mips/builtins-mips.cc View 1 2 3 43 chunks +29 lines, -82 lines 0 comments Download
A + src/builtins/mips64/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/mips64/builtins-mips64.cc View 1 2 3 43 chunks +29 lines, -79 lines 0 comments Download
A + src/builtins/ppc/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/ppc/builtins-ppc.cc View 1 2 3 43 chunks +2 lines, -57 lines 0 comments Download
A + src/builtins/s390/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/s390/builtins-s390.cc View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/x64/builtins-x64.cc View 1 2 3 37 chunks +19 lines, -66 lines 0 comments Download
A + src/builtins/x87/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/builtins/x87/builtins-x87.cc View 1 2 3 35 chunks +12 lines, -58 lines 0 comments Download
M src/compiler/code-assembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/counters.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D src/ia32/builtins-ia32.cc View 1 2 3 1 chunk +0 lines, -3093 lines 0 comments Download
M src/interpreter/interpreter.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D src/mips/builtins-mips.cc View 1 2 3 1 chunk +0 lines, -3076 lines 0 comments Download
D src/mips64/builtins-mips64.cc View 1 2 3 1 chunk +0 lines, -3068 lines 0 comments Download
M src/objects.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D src/ppc/builtins-ppc.cc View 1 2 3 1 chunk +0 lines, -3063 lines 0 comments Download
D src/s390/builtins-s390.cc View 1 2 3 1 chunk +0 lines, -3024 lines 0 comments Download
M src/v8.gyp View 1 2 3 19 chunks +11 lines, -11 lines 0 comments Download
D src/x64/builtins-x64.cc View 1 2 3 1 chunk +0 lines, -3138 lines 0 comments Download
D src/x87/builtins-x87.cc View 1 2 3 1 chunk +0 lines, -3118 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Yang
Please take a look. This change is purely mechanical and does not change any code ...
4 years, 5 months ago (2016-07-13 13:19:36 UTC) #1
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-14 04:26:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145023002/20001
4 years, 5 months ago (2016-07-14 05:41:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9062) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-14 05:42:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145023002/30001
4 years, 5 months ago (2016-07-14 05:58:33 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:30001)
4 years, 5 months ago (2016-07-14 06:26:12 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 06:26:14 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 06:28:03 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c8a0c0bdadbb79cc5e3cd50a59a4ef93a9a0d5b2
Cr-Commit-Position: refs/heads/master@{#37740}

Powered by Google App Engine
This is Rietveld 408576698