Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: net/spdy/spdy_stream.h

Issue 2144933005: Move some SpdyHeaderBlock instances from heap to stack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index 142a62a1e07b43bc7705ddcd3c0c33787f115da9..4602fe7454587682c5bfa60e6105258c3b1c6a26 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -373,7 +373,7 @@ class NET_EXPORT_PRIVATE SpdyStream {
// bidirectional streams; for request/response streams, it must be
// MORE_DATA_TO_SEND if the request has data to upload, or
// NO_MORE_DATA_TO_SEND if not.
- int SendRequestHeaders(std::unique_ptr<SpdyHeaderBlock> request_headers,
+ int SendRequestHeaders(SpdyHeaderBlock request_headers,
SpdySendStatus send_status);
// Sends a DATA frame. The delegate will be notified via
@@ -477,11 +477,6 @@ class NET_EXPORT_PRIVATE SpdyStream {
// already be activated.
std::unique_ptr<SpdySerializedFrame> ProduceSynStreamFrame();
- // Produce the initial HEADER frame for the stream with the given
- // block. The stream must already be activated.
- std::unique_ptr<SpdySerializedFrame> ProduceHeaderFrame(
- std::unique_ptr<SpdyHeaderBlock> header_block);
-
// Queues the send for next frame of the remaining data in
// |pending_send_data_|. Must be called only when
// |pending_send_data_| is set.
@@ -530,7 +525,8 @@ class NET_EXPORT_PRIVATE SpdyStream {
//
// TODO(akalin): Hang onto this only until we send it. This
// necessitates stashing the URL separately.
- std::unique_ptr<SpdyHeaderBlock> request_headers_;
+ bool request_headers_valid_;
+ SpdyHeaderBlock request_headers_;
// Data waiting to be sent, and the close state of the local endpoint
// after the data is fully written.
« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698