Move some SpdyHeaderBlock instances from heap to stack.

net/spdy/spdy_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_STREAM_H_
 #define NET_SPDY_SPDY_STREAM_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 355 matching lines @@
 
   // Only one send can be in flight at a time, except for push
   // streams, which must not send anything.
 
   // Sends the request headers. The delegate is called back via
   // OnRequestHeadersSent() when the request headers have completed
   // sending. |send_status| must be MORE_DATA_TO_SEND for
   // bidirectional streams; for request/response streams, it must be
   // MORE_DATA_TO_SEND if the request has data to upload, or
   // NO_MORE_DATA_TO_SEND if not.
-  int SendRequestHeaders(std::unique_ptr<SpdyHeaderBlock> request_headers,
+  int SendRequestHeaders(SpdyHeaderBlock request_headers,
                          SpdySendStatus send_status);
 
   // Sends a DATA frame. The delegate will be notified via
   // OnDataSent() when the send is complete. |send_status| must be
   // MORE_DATA_TO_SEND for bidirectional streams; for request/response
   // streams, it must be MORE_DATA_TO_SEND if there is more data to
   // upload, or NO_MORE_DATA_TO_SEND if not.
   void SendData(IOBuffer* data, int length, SpdySendStatus send_status);
 
   // Fills SSL info in |ssl_info| and returns true when SSL is in use.
@@ skipping 83 matching lines @@
   // FIN states received prior to the delegate being attached have not yet been
   // read. While buffered by |pending_recv_data_| it's not until
   // PushedStreamReplay() is invoked that reads are considered
   // to have occurred, driving the state machine forward.
   void PushedStreamReplay();
 
   // Produces the SYN_STREAM frame for the stream. The stream must
   // already be activated.
   std::unique_ptr<SpdySerializedFrame> ProduceSynStreamFrame();
 
-  // Produce the initial HEADER frame for the stream with the given
-  // block. The stream must already be activated.
-  std::unique_ptr<SpdySerializedFrame> ProduceHeaderFrame(
-      std::unique_ptr<SpdyHeaderBlock> header_block);
-
   // Queues the send for next frame of the remaining data in
   // |pending_send_data_|. Must be called only when
   // |pending_send_data_| is set.
   void QueueNextDataFrame();
 
   // Merge the given headers into |response_headers_| and calls
   // OnResponseHeadersUpdated() on the delegate (if attached).
   // Returns a status code; if it is an error, the stream was closed
   // by this function.
   int MergeWithResponseHeaders(const SpdyHeaderBlock& new_response_headers);
@@ skipping 28 matching lines @@
 
   const base::WeakPtr<SpdySession> session_;
 
   // The transaction should own the delegate.
   SpdyStream::Delegate* delegate_;
 
   // The headers for the request to send.
   //
   // TODO(akalin): Hang onto this only until we send it. This
   // necessitates stashing the URL separately.
-  std::unique_ptr<SpdyHeaderBlock> request_headers_;
+  bool request_headers_valid_;
+  SpdyHeaderBlock request_headers_;
 
   // Data waiting to be sent, and the close state of the local endpoint
   // after the data is fully written.
   scoped_refptr<DrainableIOBuffer> pending_send_data_;
   SpdySendStatus pending_send_status_;
 
   // Data waiting to be received, and the close state of the remote endpoint
   // after the data is fully read. Specifically, data received before the
   // delegate is attached must be buffered and later replayed. A remote FIN
   // is represented by a final, zero-length buffer.
@@ skipping 37 matching lines @@
   bool write_handler_guard_;
 
   base::WeakPtrFactory<SpdyStream> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyStream);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_STREAM_H_