Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2144853002: Remove references to blink::WebPageOverlay. (Closed)

Created:
4 years, 5 months ago by jbroman
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, Rick Byers
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-test-runner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to blink::WebPageOverlay. This interface no longer exists; overlays are only implemented within Blink and are no longer part of the public API. (Since https://codereview.chromium.org/1264483002) TBR=rbyers@chromium.org Committed: https://crrev.com/e3f134a07ac47ca147e0b3cfa55bf0445480c402 Cr-Commit-Position: refs/heads/master@{#404967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M components/test_runner/test_runner_for_specific_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
jbroman
trivial; was looking at the page overlay code and ran across this
4 years, 5 months ago (2016-07-12 21:20:31 UTC) #3
chrishtr
lgtm
4 years, 5 months ago (2016-07-12 21:23:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144853002/1
4 years, 5 months ago (2016-07-12 21:25:16 UTC) #6
jbroman
TBR-ing rbyers@chromium.org for the test_runner change (it's just removing a few words from a comment)
4 years, 5 months ago (2016-07-12 21:26:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191832)
4 years, 5 months ago (2016-07-13 00:38:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144853002/1
4 years, 5 months ago (2016-07-13 01:04:50 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:36:40 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:36:57 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3f134a07ac47ca147e0b3cfa55bf0445480c402 Cr-Commit-Position: refs/heads/master@{#404967}
4 years, 5 months ago (2016-07-13 03:40:03 UTC) #17
Rick Byers
4 years, 5 months ago (2016-07-13 10:56:45 UTC) #18
Message was sent while issue was closed.
On 2016/07/12 21:26:01, jbroman wrote:
> TBR-ing mailto:rbyers@chromium.org for the test_runner change (it's just
removing a few
> words from a comment)

LGTM

Powered by Google App Engine
This is Rietveld 408576698