Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264483002: PageOverlays: Remove PageOverlayList (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PageOverlays: Remove PageOverlayList BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199869

Patch Set 1 #

Total comments: 6

Patch Set 2 : Move WebPageOverlay to PageOverlay #

Total comments: 10

Patch Set 3 : Address comment #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -387 lines) Patch
M Source/web/InspectorOverlayImpl.h View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 5 chunks +29 lines, -19 lines 0 comments Download
M Source/web/PageOverlay.h View 1 2 3 chunks +13 lines, -12 lines 0 comments Download
M Source/web/PageOverlay.cpp View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
D Source/web/PageOverlayList.h View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/web/PageOverlayList.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
M Source/web/PageOverlayTest.cpp View 1 6 chunks +7 lines, -10 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 2 3 7 chunks +3 lines, -7 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 7 chunks +25 lines, -26 lines 0 comments Download
M Source/web/painting/ContinuousPainter.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/painting/ContinuousPainter.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M Source/web/web.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D public/web/WebPageOverlay.h View 1 chunk +0 lines, -49 lines 0 comments Download
M public/web/WebView.h View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
sergeyv
5 years, 4 months ago (2015-07-28 15:41:01 UTC) #2
dgozman
https://codereview.chromium.org/1264483002/diff/1/Source/web/WebPageOverlay.h File Source/web/WebPageOverlay.h (right): https://codereview.chromium.org/1264483002/diff/1/Source/web/WebPageOverlay.h#newcode40 Source/web/WebPageOverlay.h:40: class BLINK_EXPORT WebPageOverlay { Let's rename this to PageOverlayDelegate. ...
5 years, 4 months ago (2015-07-28 16:16:57 UTC) #3
sergeyv
@dgozman, can you please take a look? https://codereview.chromium.org/1264483002/diff/1/Source/web/WebPageOverlay.h File Source/web/WebPageOverlay.h (right): https://codereview.chromium.org/1264483002/diff/1/Source/web/WebPageOverlay.h#newcode40 Source/web/WebPageOverlay.h:40: class BLINK_EXPORT ...
5 years, 4 months ago (2015-07-29 18:12:36 UTC) #4
dgozman
https://codereview.chromium.org/1264483002/diff/20001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1264483002/diff/20001/Source/web/InspectorOverlayImpl.cpp#newcode531 Source/web/InspectorOverlayImpl.cpp:531: void InspectorOverlayImpl::updatePageOverlay() updateGraphicsLayer? Or even better replace two methods ...
5 years, 4 months ago (2015-07-30 10:17:31 UTC) #5
sergeyv
https://codereview.chromium.org/1264483002/diff/20001/Source/web/InspectorOverlayImpl.cpp File Source/web/InspectorOverlayImpl.cpp (right): https://codereview.chromium.org/1264483002/diff/20001/Source/web/InspectorOverlayImpl.cpp#newcode531 Source/web/InspectorOverlayImpl.cpp:531: void InspectorOverlayImpl::updatePageOverlay() On 2015/07/30 10:17:31, dgozman wrote: > updateGraphicsLayer? ...
5 years, 4 months ago (2015-07-30 11:42:38 UTC) #6
dgozman
lgtm
5 years, 4 months ago (2015-07-30 11:51:00 UTC) #7
sergeyv
@pfeldman, can you please take a look?
5 years, 4 months ago (2015-07-30 12:07:10 UTC) #8
pfeldman
owner lgtm. @dgozman: you should be the web/ owner.
5 years, 4 months ago (2015-07-31 18:44:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264483002/40001
5 years, 4 months ago (2015-07-31 22:49:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38913)
5 years, 4 months ago (2015-07-31 22:51:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264483002/60001
5 years, 4 months ago (2015-08-02 17:53:54 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-02 19:03:24 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199869

Powered by Google App Engine
This is Rietveld 408576698