Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144823003: [Android] Blacklist devices on failures during environment set up + tear down. (Closed)

Created:
4 years, 5 months ago by jbudorick
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Blacklist devices on failures during environment set up + tear down. Requires https://codereview.chromium.org/2144103002/ BUG=627939 Committed: https://crrev.com/84c46fae5808a0a2ac1a851e51208fa9343eaafb Cr-Commit-Position: refs/heads/master@{#407594}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rnephew comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -65 lines) Patch
M build/android/pylib/local/device/local_device_environment.py View 1 6 chunks +72 lines, -12 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 3 chunks +3 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_perf_test_run.py View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 3 chunks +2 lines, -47 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbudorick
4 years, 5 months ago (2016-07-13 20:04:03 UTC) #2
rnephew (Reviews Here)
lgtm with one super-nit https://codereview.chromium.org/2144823003/diff/1/build/android/pylib/local/device/local_device_environment.py File build/android/pylib/local/device/local_device_environment.py (right): https://codereview.chromium.org/2144823003/diff/1/build/android/pylib/local/device/local_device_environment.py#newcode142 build/android/pylib/local/device/local_device_environment.py:142: nit: one line
4 years, 5 months ago (2016-07-13 20:12:26 UTC) #3
jbudorick
will land after the requisite catapult roll https://codereview.chromium.org/2144823003/diff/1/build/android/pylib/local/device/local_device_environment.py File build/android/pylib/local/device/local_device_environment.py (right): https://codereview.chromium.org/2144823003/diff/1/build/android/pylib/local/device/local_device_environment.py#newcode142 build/android/pylib/local/device/local_device_environment.py:142: On 2016/07/13 ...
4 years, 5 months ago (2016-07-13 20:43:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144823003/40001
4 years, 5 months ago (2016-07-25 19:34:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 21:44:05 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:46:17 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/84c46fae5808a0a2ac1a851e51208fa9343eaafb
Cr-Commit-Position: refs/heads/master@{#407594}

Powered by Google App Engine
This is Rietveld 408576698