build/android/pylib/local/device/local_device_gtest_run.py - Issue 2144823003: [Android] Blacklist devices on failures during environment set up + tear down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2144823003: [Android] Blacklist devices on failures during environment set up + tear down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/local/device/local_device_environment.py ('k') | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/local/device/local_device_gtest_run.py

diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py

index 3a299ef9c444f24352b746474388dfed33bd2cc1..72961708288aa54ea3b630a069d8788ebd00a2b3 100644

--- a/build/android/pylib/local/device/local_device_gtest_run.py

+++ b/build/android/pylib/local/device/local_device_gtest_run.py

@@ -232,7 +232,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

#override

def SetUp(self):

- @local_device_test_run.handle_shard_failures_with(

+ @local_device_environment.handle_shard_failures_with(

on_failure=self._env.BlacklistDevice)

def individual_device_set_up(dev):

def install_apk():

@@ -313,7 +313,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

# Even when there's only one device, it still makes sense to retrieve the

# test list so that tests can be split up and run in batches rather than all

# at once (since test output is not streamed).

- @local_device_test_run.handle_shard_failures_with(

+ @local_device_environment.handle_shard_failures_with(

on_failure=self._env.BlacklistDevice)

def list_tests(dev):

raw_test_list = self._delegate.Run(

@@ -363,7 +363,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):

#override

def TearDown(self):

- @local_device_test_run.handle_shard_failures

+ @local_device_environment.handle_shard_failures

def individual_device_tear_down(dev):

for s in self._servers.get(str(dev), []):

s.TearDown()