Rename RenderStyle::diff and RenderStyle::compare to better names

Rename RenderStyle::diff and RenderStyle::compare to better names

Having both ::compare() and ::diff() was really confusing, this patch
renames them to stylePropagationDiff() and visualInvalidationDiff()
making their purpose more clear.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170223

[rune, 2014-03-27 11:50:51]

lgtm if spelling is fixed.

https://codereview.chromium.org/214473004/diff/20001/Source/core/rendering/st...
File Source/core/rendering/style/RenderStyle.h (right):

https://codereview.chromium.org/214473004/diff/20001/Source/core/rendering/st...
Source/core/rendering/style/RenderStyle.h:359: // Computes how the style change
should be propogated through the tree.

Minor nit: I think I would have said "down the tree" instead of "through the
tree", but you're the native speaker here.

https://codereview.chromium.org/214473004/diff/20001/Source/core/rendering/st...
Source/core/rendering/style/RenderStyle.h:360: static StyleRecalcChange
stylePropogationDiff(const RenderStyle* oldStyle, const RenderStyle* newStyle);

Propogation -> Propagation

Same misspelling in the CL description.

[esprehn, 2014-03-27 11:59:20]

Fixed the typos.

[esprehn, 2014-03-27 11:59:26]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 11:59:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/214473004/40001

[commit-bot: I haz the power, 2014-03-27 13:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 13:09:09]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-27 13:10:27]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 13:10:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/214473004/40001

[commit-bot: I haz the power, 2014-03-27 14:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 14:25:23]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-27 18:44:37]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 18:44:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/214473004/40001

[commit-bot: I haz the power, 2014-03-27 20:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 20:42:01]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-27 20:48:48]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 20:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/214473004/40001

[commit-bot: I haz the power, 2014-03-27 22:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:32:43]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[esprehn, 2014-03-27 22:36:19]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-27 22:36:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/214473004/40001

[commit-bot: I haz the power, 2014-03-27 23:48:24]

Change committed as 170223