Source/core/rendering/RenderBlock.cpp - Issue 214473004: Rename RenderStyle::diff and RenderStyle::compare to better names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 214473004: Rename RenderStyle::diff and RenderStyle::compare to better names (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: typos Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RenderBlock.cpp

diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp

index 906a00cb648fe8b3367e9422eecb80b449c3e92e..9c02b678e15da8b9773c9d34de73b071c41993ca 100644

--- a/Source/core/rendering/RenderBlock.cpp

+++ b/Source/core/rendering/RenderBlock.cpp

@@ -4070,7 +4070,7 @@ void RenderBlock::updateFirstLetterStyle(RenderObject* firstLetterBlock, RenderO

RenderStyle* pseudoStyle = styleForFirstLetter(firstLetterBlock, firstLetterContainer);

ASSERT(firstLetter->isFloating() || firstLetter->isInline());

- if (RenderStyle::compare(firstLetter->style(), pseudoStyle) == Reattach) {

+ if (RenderStyle::stylePropagationDiff(firstLetter->style(), pseudoStyle) == Reattach) {

// The first-letter renderer needs to be replaced. Create a new renderer of the right type.

RenderBoxModelObject* newFirstLetter;

if (pseudoStyle->display() == INLINE)