Remove ContentViewCore::GetDpiScale.

Remove ContentViewCore::GetDpiScale.

This is part of an effort to remove/split up ContentViewCore

BUG=626788
Committed: https://crrev.com/00aa0b3010a821f1687589ce0d48cf9b81589b50
Cr-Commit-Position: refs/heads/master@{#405456}

[gsennton, 2016-07-13 13:56:25]

gsennton@chromium.org changed reviewers:
+ sievers@chromium.org

[gsennton, 2016-07-13 13:56:25]

Hi sievers@, you cover all the files in this change. Should I be adding
yfriedman@ here as a more specific owner of content/browser/android/?

This CL removes the public GetDpiScale method from CVC but it doesn't remove the
internal dpi_scale_/dpi_scale() variable/method from CVCImpl, I guess that is
something we want to do as well?

Also, the PopupTouchHandleDrawable and the OverScrollControllerAndroid classes
still store their own dpi_scale values, which is something we could potentially
remove (and let them refer to a ViewAndroid?) buuut I don't want to get into
that in this CL :)

[no sievers, 2016-07-13 17:51:47]

On 2016/07/13 13:56:25, gsennton wrote:
> Hi sievers@, you cover all the files in this change. Should I be adding
> yfriedman@ here as a more specific owner of content/browser/android/?
> 
> This CL removes the public GetDpiScale method from CVC but it doesn't remove
the
> internal dpi_scale_/dpi_scale() variable/method from CVCImpl, I guess that is
> something we want to do as well?
> 

It's only used for view_.GetWindowAndroid()->set_content_offset().
Maybe that can be removed later when WindowAndroid can get to the dpi scale
directly.


> Also, the PopupTouchHandleDrawable and the OverScrollControllerAndroid classes
> still store their own dpi_scale values, which is something we could
potentially
> remove (and let them refer to a ViewAndroid?) buuut I don't want to get into
> that in this CL :)

Sounds good. lgtm, thanks!

[no sievers, 2016-07-13 17:51:53]

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
File content/browser/android/overscroll_controller_android.cc (right):

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
content/browser/android/overscroll_controller_android.cc:100:
ContentViewCoreImpl* content_view_core,
Now you can pass OverscrollRefreshHandler* instead of CVC*.

[gsennton, 2016-07-13 18:38:39]

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
File content/browser/android/overscroll_controller_android.cc (right):

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
content/browser/android/overscroll_controller_android.cc:100:
ContentViewCoreImpl* content_view_core,
On 2016/07/13 17:51:53, sievers wrote:
> Now you can pass OverscrollRefreshHandler* instead of CVC*.

If we also pass the Compositor yup :P

[gsennton, 2016-07-13 19:24:30]

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
File content/browser/android/overscroll_controller_android.cc (right):

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
content/browser/android/overscroll_controller_android.cc:100:
ContentViewCoreImpl* content_view_core,
On 2016/07/13 18:38:39, gsennton wrote:
> On 2016/07/13 17:51:53, sievers wrote:
> > Now you can pass OverscrollRefreshHandler* instead of CVC*.
> 
> If we also pass the Compositor yup :P

Can I submit as is or would you like me to change this as well?

[no sievers, 2016-07-13 19:26:33]

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
File content/browser/android/overscroll_controller_android.cc (right):

https://codereview.chromium.org/2144703003/diff/1/content/browser/android/ove...
content/browser/android/overscroll_controller_android.cc:100:
ContentViewCoreImpl* content_view_core,
Ooops nevermind then.

Maybe eventually this can take a ViewAndroid or WindowAndroid.
And the OverscrollRefreshHandler (for pull-to-refresh) seems to be routed
through ContentViewCore.java for no particularly good reason. (Looks like we
could talk to SwipeRefreshHandler.java directly from here.) Filed
crbug.com/627943 for that.

[gsennton, 2016-07-14 09:00:08]

The CQ bit was checked by gsennton@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:00:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 09:32:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 09:32:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 09:34:18]

Description was changed from

==========
Remove ContentViewCore::GetDpiScale.

This is part of an effort to remove/split up ContentViewCore

BUG=626788
==========

to

==========
Remove ContentViewCore::GetDpiScale.

This is part of an effort to remove/split up ContentViewCore

BUG=626788

Committed: https://crrev.com/00aa0b3010a821f1687589ce0d48cf9b81589b50
Cr-Commit-Position: refs/heads/master@{#405456}
==========

[commit-bot: I haz the power, 2016-07-14 09:34:19]

Patchset 1 (id:??) landed as
https://crrev.com/00aa0b3010a821f1687589ce0d48cf9b81589b50
Cr-Commit-Position: refs/heads/master@{#405456}