Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: content/browser/android/overscroll_controller_android.cc

Issue 2144703003: Remove ContentViewCore::GetDpiScale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/overscroll_controller_android.cc
diff --git a/content/browser/android/overscroll_controller_android.cc b/content/browser/android/overscroll_controller_android.cc
index 8feda1cba252ea5fbdf1d81fb68a07288ef163f4..5e8917259d7b39812766e11b054948d99a9c0622 100644
--- a/content/browser/android/overscroll_controller_android.cc
+++ b/content/browser/android/overscroll_controller_android.cc
@@ -97,9 +97,10 @@ std::unique_ptr<OverscrollRefresh> CreateRefreshEffect(
} // namespace
OverscrollControllerAndroid::OverscrollControllerAndroid(
- ContentViewCoreImpl* content_view_core)
+ ContentViewCoreImpl* content_view_core,
no sievers 2016/07/13 17:51:53 Now you can pass OverscrollRefreshHandler* instead
gsennton 2016/07/13 18:38:39 If we also pass the Compositor yup :P
gsennton 2016/07/13 19:24:30 Can I submit as is or would you like me to change
no sievers 2016/07/13 19:26:32 Ooops nevermind then. Maybe eventually this can t
+ float dpi_scale)
: compositor_(content_view_core->GetWindowAndroid()->GetCompositor()),
- dpi_scale_(content_view_core->GetDpiScale()),
+ dpi_scale_(dpi_scale),
enabled_(true),
glow_effect_(CreateGlowEffect(this, dpi_scale_)),
refresh_effect_(CreateRefreshEffect(content_view_core)) {
« no previous file with comments | « content/browser/android/overscroll_controller_android.h ('k') | content/browser/android/popup_touch_handle_drawable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698