Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2144673003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in SearchBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whoops, let's maybe compile first. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 46f0e4e9db3754df5c7ad65b9dba9c631ad73c87..73e5014f20f733fd005a08924ee60cd9e20fc8a3 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -1233,6 +1233,10 @@ void Editor::computeAndSetTypingStyle(StylePropertySet* style, EditAction editin
bool Editor::findString(const String& target, FindOptions options)
{
+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+ // see http://crbug.com/590369 for more details.
+ frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
dglazkov 2016/07/13 22:40:11 This can go up one more, to EditorCommand and Loca
+
VisibleSelection selection = frame().selection().selection();
// TODO(yosin) We should make |findRangeOfString()| to return
@@ -1249,6 +1253,10 @@ bool Editor::findString(const String& target, FindOptions options)
Range* Editor::findStringAndScrollToVisible(const String& target, Range* previousMatch, FindOptions options)
{
+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+ // see http://crbug.com/590369 for more details.
+ frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
dglazkov 2016/07/13 22:40:10 This can go up one more as well, to WebLocalFrameI
+
Range* nextMatch = findRangeOfString(target, EphemeralRangeInFlatTree(previousMatch), options);
if (!nextMatch)
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698